Skip to content

Commit 4af18e6

Browse files
committed
fix: modify according to the review comments
Signed-off-by: Daniel Hu <[email protected]>
1 parent 7e0c44e commit 4af18e6

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

cmd/devstream/develop.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ func developCMDFunc(cmd *cobra.Command, args []string) {
2626
}
2727

2828
developAction := develop.Action(args[0])
29-
log.Debugf("The develop action is: %s", developAction)
30-
if err := develop.BranchAction(developAction); err != nil {
29+
log.Debugf("The develop action is: %s.", developAction)
30+
if err := develop.ExecuteAction(developAction); err != nil {
3131
log.Fatal(err)
3232
}
3333
}

internal/pkg/develop/develop.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ func IsValideAction(action Action) bool {
2020
return ok
2121
}
2222

23-
func BranchAction(action Action) error {
23+
func ExecuteAction(action Action) error {
2424
switch action {
2525
case ActionCreatePlugin:
26-
log.Debugf("Action: %s", ActionCreatePlugin)
26+
log.Debugf("Action: %s.", ActionCreatePlugin)
2727
return plugin.Create()
2828
default:
2929
panic("This should be never happen!")

internal/pkg/develop/plugin/plugin.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ func (p *Plugin) PersistFiles(files []pluginTpl.File) error {
9696
fileCount := len(files)
9797
log.Debugf("There are %d files wait to persist.", fileCount)
9898
for i, file := range files {
99-
log.Debugf("Persist process: %d/%d", i+1, fileCount)
99+
log.Debugf("Persist process: %d/%d.", i+1, fileCount)
100100
if err := p.persistFile(&file); err != nil {
101-
log.Errorf("Failed to persist: %s/%s", file.Dir, file.Name)
101+
log.Errorf("Failed to persist: %s/%s.", file.Dir, file.Name)
102102
return err
103103
}
104104
}

0 commit comments

Comments
 (0)