Feat: Adding Defaults() to util/helm (#182)

Signed-off-by: Daniel Hu <[email protected]>

Author: daniel-hutao

docs/argocd_plugin.md

@@ -31,7 +31,7 @@ tools:
       namespace: argocd
       # whether to wait for the release to be deployed or not
       wait: true
-      # the time to wait for any individual Kubernetes operation (like Jobs for hooks)
+      # the time to wait for any individual Kubernetes operation (like Jobs for hooks). This defaults to 5m0s
       timeout: 5m
       # whether to perform a CRD upgrade during installation
       upgradeCRDs: true

docs/kube-prometheus_plugin.md

@@ -33,7 +33,7 @@ tools:
       namespace: monitoring
       # whether to wait for the release to be deployed or not
       wait: true
-      # the time to wait for any individual Kubernetes operation (like Jobs for hooks)
+      # the time to wait for any individual Kubernetes operation (like Jobs for hooks). This defaults to 5m0s
       timeout: 5m
       # whether to perform a CRD upgrade during installation
       upgradeCRDs: true

pkg/util/helm/validation.go

@@ -3,6 +3,8 @@ package helm
 import "fmt"
 
 func Validate(param *HelmParam) []error {
+	Defaults(param)
+
 	retErrors := make([]error, 0)
 
 	if param.Repo.Name == "" {
@@ -17,3 +19,12 @@ func Validate(param *HelmParam) []error {
 
 	return retErrors
 }
+
+// Defaults set the default value with HelmParam.
+// TODO(daniel-hutao): don't call this function insides the Validate()
+func Defaults(param *HelmParam) {
+	if param.Chart.Timeout == "" {
+		// Make the timeout be same as the default value for `--timeout` with `helm install/upgrade/rollback`
+		param.Chart.Timeout = "5m0s"
+	}
+}