Merge pull request #92 from daniel-hutao/dev-1

fix: #89 #90 - logs format improved

Author: daniel-hutao

cmd/argocd/main.go

@@ -1,7 +1,7 @@
 package main
 
 import (
-	"fmt"
+	"log"
 
 	"github.com/merico-dev/stream/internal/pkg/argocd"
 )
@@ -31,5 +31,5 @@ func (p Plugin) Uninstall(options *map[string]interface{}) (bool, error) {
 var DevStreamPlugin Plugin
 
 func main() {
-	fmt.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
+	log.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
 }

cmd/argocdapp/main.go

@@ -1,7 +1,7 @@
 package main
 
 import (
-	"fmt"
+	"log"
 
 	"github.com/merico-dev/stream/internal/pkg/argocdapp"
 )
@@ -31,5 +31,5 @@ func (p Plugin) Uninstall(options *map[string]interface{}) (bool, error) {
 var DevStreamPlugin Plugin
 
 func main() {
-	fmt.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
+	log.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
 }

cmd/devstream/init.go

@@ -23,4 +23,5 @@ func initCMDFunc(cmd *cobra.Command, args []string) {
 		log.Printf("Error: %s", err)
 		return
 	}
+	log.Println("=== initialize finished ===")
 }

cmd/githubactions/main.go

@@ -1,7 +1,7 @@
 package main
 
 import (
-	"fmt"
+	"log"
 
 	"github.com/merico-dev/stream/internal/pkg/githubactions"
 )
@@ -31,5 +31,5 @@ func (p Plugin) Uninstall(options *map[string]interface{}) (bool, error) {
 var DevStreamPlugin Plugin
 
 func main() {
-	fmt.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
+	log.Printf("%T: %s is a plugin for DevStream. Use it with DevStream.\n", NAME, DevStreamPlugin)
 }

internal/pkg/pluginengine/plugin.go

@@ -46,20 +46,17 @@ func loadPlugin(tool *configloader.Tool) (DevStreamPlugin, error) {
 	mod := fmt.Sprintf("plugins/%s_%s.so", tool.Name, tool.Version)
 	plug, err := plugin.Open(mod)
 	if err != nil {
-		fmt.Println(err)
 		return nil, err
 	}
 
 	var devStreamPlugin DevStreamPlugin
 	symDevStreamPlugin, err := plug.Lookup("DevStreamPlugin")
 	if err != nil {
-		fmt.Println(err)
 		return nil, err
 	}
 
 	devStreamPlugin, ok := symDevStreamPlugin.(DevStreamPlugin)
 	if !ok {
-		fmt.Println(err)
 		return nil, err
 	}
 

internal/pkg/pluginmanager/manager.go

@@ -20,13 +20,14 @@ func DownloadPlugins(conf *configloader.Config) error {
 		pluginFileName := configloader.GetPluginFileName(&tool)
 		if _, err := os.Stat(filepath.Join(pluginsDir, pluginFileName)); errors.Is(err, os.ErrNotExist) {
 			// plugin does not exist
-			log.Printf("=== now downloading plugin: %s ,version: %s === \n", pluginFileName, tool.Version)
+			log.Printf("=== now downloading plugin: %s, version: %s ===", pluginFileName, tool.Version)
 			err := dc.download(pluginsDir, pluginFileName, tool.Version)
 			if err != nil {
 				return err
 			}
-			log.Printf("=== plugin: %s ,version: %s downloaded === \n", pluginFileName, tool.Version)
+			log.Printf("=== plugin: %s, version: %s downloaded ===", pluginFileName, tool.Version)
 		}
+		log.Printf("=== plugin: %s, version: %s is exists ===", pluginFileName, tool.Version)
 	}
 
 	return nil

internal/pkg/statemanager/state.go

@@ -15,9 +15,9 @@ const (
 	StatusUninstalled ComponentStatus = "uninstalled"
 	// We use StatusInstalled when a plugin is installed but we don't know its status is "running" or "failed".
 	// For example: We try to uninstall a plugin but failed for some reason.
-	StatusInstalled   ComponentStatus = "installed"
-	StatusRunning     ComponentStatus = "running"
-	StatusFailed      ComponentStatus = "failed"
+	StatusInstalled ComponentStatus = "installed"
+	StatusRunning   ComponentStatus = "running"
+	StatusFailed    ComponentStatus = "failed"
 )
 
 const (