feat: check duplicate tools and pipeline templates

Signed-off-by: Bird <[email protected]>

Author: aFlyBird0

internal/pkg/configmanager/rawconfig.go

@@ -7,6 +7,8 @@ import (
 	"unicode"
 
 	"gopkg.in/yaml.v3"
+
+	"github.com/devstream-io/devstream/pkg/util/log"
 )
 
 // rawConfig respent every valid config block for devstream
@@ -46,9 +48,15 @@ func newRawConfigFromConfigBytes(fileText []byte) (*rawConfig, error) {
 		case "pipelineTemplates":
 			rawConfigData.pipelineTemplates = append(rawConfigData.pipelineTemplates, matchStr...)
 		case "config":
+			if len(rawConfigData.config) != 0 {
+				return nil, fmt.Errorf("<config> key can only be defined once")
+			}
 			rawConfigData.config = append(rawConfigData.config, matchStr...)
 		case "vars":
 			rawConfigData.vars = append(rawConfigData.vars, matchStr...)
+		default:
+			const errHint = "you may have filled in the wrong key or imported a yaml file that is not related to dtm"
+			return nil, fmt.Errorf("invalid config key <%s>, %s", string(configKey), errHint)
 		}
 	}
 	if err := rawConfigData.validate(); err != nil {
@@ -127,6 +135,10 @@ func (c *rawConfig) getTemplatePipelineMap() (map[string]string, error) {
 		if err != nil {
 			return nil, err
 		}
+		if _, ok := pipelineTemplateMap[t.Name]; ok {
+			return nil, fmt.Errorf("pipelineTemplate <%s> is duplicated", t.Name)
+		}
+		log.Infof("pipelineTemplate %s is loaded", t.Name)
 		pipelineTemplateMap[t.Name] = string(rawPipeline)
 	}
 	return pipelineTemplateMap, nil

internal/pkg/configmanager/tool.go

@@ -66,6 +66,7 @@ func (tools Tools) validate() (errs []error) {
 	for _, tool := range tools {
 		errs = append(errs, tool.validate()...)
 	}
+	errs = append(errs, tools.DuplicatedCheck()...)
 	return
 }
 
@@ -116,6 +117,22 @@ func (t *Tool) GetPluginMD5FileNameWithOSAndArch(os, arch string) string {
 	return t.GetPluginNameWithOSAndArch(os, arch) + ".md5"
 }
 
+func (t *Tool) EqualNameAndInstanceID(other *Tool) bool {
+	return t.Name == other.Name && t.InstanceID == other.InstanceID
+}
+
+func (tools Tools) DuplicatedCheck() (errs []error) {
+	list := make(map[string]struct{})
+	for _, t := range tools {
+		key := t.KeyWithNameAndInstanceID()
+		if _, ok := list[key]; ok {
+			errs = append(errs, fmt.Errorf("tool or app <%s> is duplicated", key))
+		}
+		list[key] = struct{}{}
+	}
+	return errs
+}
+
 // validateDependsOnConfig is used to validate all tools' DependsOn config
 func (tools Tools) validateDependsOnConfig() (retErrs []error) {
 	retErrs = make([]error, 0)
@@ -137,7 +154,7 @@ func (tools Tools) validateDependsOnConfig() (retErrs []error) {
 			}
 
 			if _, ok := toolKeySet[d]; !ok {
-				errs = append(errs, fmt.Errorf("t %s's DependsOn %s doesn't exist", tool.InstanceID, d))
+				errs = append(errs, fmt.Errorf("tool %s's DependsOn %s doesn't exist", tool.InstanceID, d))
 			}
 		}
 		return