fix: change according bird's review comment

daniel-hutao · daniel-hutao · commit d31c4fbad1b3 · 2022-11-29T12:04:00.000+08:00
Signed-off-by: Daniel Hu &lt;tao.hu@merico.dev&gt;
diff --git a/internal/pkg/plugin/helminstaller/helminstaller.go b/internal/pkg/plugin/helminstaller/helminstaller.go
@@ -88,7 +88,7 @@ func getDefaultOptionsByInstanceID(instanceID string) *helm.Options {
 	// e.g. argocd-config-001 contains argocd and argocd-config, so the argocd and argocd-config both are matched name.
 	var matchedNames = make([]string, 0)
 	for name := range defaults.DefaultOptionsMap {
-		if strings.Contains(instanceID, name) {
+		if strings.HasPrefix(instanceID, name) {
 			matchedNames = append(matchedNames, name)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ func getDefaultOptionsByInstanceID(instanceID string) *helm.Options {`
`88`	`88`	`// e.g. argocd-config-001 contains argocd and argocd-config, so the argocd and argocd-config both are matched name.`
`89`	`89`	`var matchedNames = make([]string, 0)`
`90`	`90`	`for name := range defaults.DefaultOptionsMap {`
`91`		`- if strings.Contains(instanceID, name) {`
	`91`	`+ if strings.HasPrefix(instanceID, name) {`
`92`	`92`	`matchedNames = append(matchedNames, name)`
`93`	`93`	`}`
`94`	`94`	`}`