dataset encryption

[thoto]

encrypt each users dataset using a key based on the users pin.

[undermink]

hmm I guess this would do: https://github.com/delatbabel/elocryptfive
I'll give it a try...

[thoto]

Nice.
It could work but if I got that right, it does neither store which algorithm it uses nor is there any method to derive the key used for a dataset from the users pin or password. It would be awesome if there would not be a single point of failure for decryption and we would not need to trust the admin and the security of our keystore.
I know that a short (e.g. four digit) pin does not perform well in terms of key length but it may be possible to improve that using a additional master key to derive a records encryption key. We also need to determine which data needs to be readable for which party, e.g. whether there is a need to store a users balance unencrypted.
Please correct me, if I'm wrong. I just took a short look at that libraries source code.
Thanks, nice work! :-)

[undermink]

Ah now I got it. Totally ignored that you wrote "based on the user's PIN". :)
In that case, I guess, I do not need that extra package anymore.

[thoto]

Of course you don't need that package, but I think it would be wise to use a separate package providing and abstracting this functionality. Maybe Eloquent or rather this Elocrypt module may be extensible in that way. I just wanted to express my personal opinion on what features I would like to see making the encryption more secure (regarding encryption based on users secrets) and kind of future proof (storing crypt algorithm alongside data).