feat: remove maxChar in getOuterHTML

max character limits should be enforced globally

Author: b10902118

packages/extension/src/htmlUtils.ts

@@ -6,37 +6,15 @@ interface StructureSummary {
   totalDepth: number;
 }
 
-/**
- * Truncates HTML based on depth and line length controls
- * @param node - The DOM node to truncate
- * @param maxDepth - Maximum nesting depth of tags to include
- * @param maxLineLength - Maximum length of each line
- * @param maxChars - Maximum number of characters
- * @returns Truncated HTML
- */
 export function truncateHTML(
-  node: Node,
+  element: Element,
   maxDepth?: number,
   maxLineLength?: number,
-  maxChars?: number,
 ): string {
-  let result: Node = node.cloneNode(true);
-
-  // Truncate by depth
-  if (maxDepth !== undefined && maxDepth > 0) {
-    for (let depth = maxDepth; depth > 0; depth--) {
-      // has to use original node each time to ensure summary is correct
-      let truncated = truncateByDepth(node, depth);
-      let html = (truncated as Element).outerHTML || truncated.textContent;
-      if (maxChars === undefined || (html && html.length < maxChars)) {
-        result = truncated;
-        break;
-      }
-    }
-  }
+  let pruned = truncateByDepth(element, maxDepth) as Element;
 
   // Get HTML string
-  let html = (result as Element).outerHTML || result.textContent || "";
+  let html = pruned.outerHTML;
   html = beautify.html(html, {
     indent_size: 2,
     wrap_line_length: 0, // Don't wrap - let truncateByLineLength handle it

packages/extension/src/offscreen_inspectors.ts

@@ -94,25 +94,15 @@ async function processRequest(
 
     case "getOuterHTML": {
       // some safe defaults
-      const {
-        node: uid,
-        maxDepth = 3,
-        maxLineLength = 200,
-        maxChars = 100000,
-      } = request;
+      const { node: uid, maxDepth = 3, maxLineLength = 200 } = request;
       const node = nodeManager.getNode(uid, inspector);
       if (!node) {
         throw new Error(`Node not found for: ${uid}`);
-      } else if (!node.tracked) {
-        throw new Error(`Node is no longer existed for: ${uid}`);
+      } else if (!(node instanceof InspectorElement)) {
+        throw new Error(`Non-element nodes do not support styles for: ${uid}`);
       }
       // Apply depth and line length controls if provided
-      const html = truncateHTML(
-        node._docNode,
-        maxDepth,
-        maxLineLength,
-        maxChars,
-      );
+      const html = truncateHTML(node._docNode, maxDepth, maxLineLength);
       console.log("serveRequest - getOuterHTML html:", html);
       return { outerHTML: html };
     }

packages/mcp/src/server.ts

@@ -160,19 +160,14 @@ export class DevToolCSSMCPServer {
             .number()
             .optional()
             .describe("Maximum line length (default: 200)"),
-          maxChars: z
-            .number()
-            .optional()
-            .describe("Maximum total characters (default: 100000)"),
         },
       },
-      async ({ node, maxDepth, maxLineLength, maxChars }) => {
+      async ({ node, maxDepth, maxLineLength }) => {
         const result = await this.wsServer.sendRequest({
           tool: "getOuterHTML",
           node,
           maxDepth,
           maxLineLength,
-          maxChars,
         });
         return {
           content: [{ type: "text", text: JSON.stringify(result, null, 2) }],