Skip to content

Commit 1331953

Browse files
authored
Merge pull request #213 from akshatsinha007/main
fix: Fixed in-cluster cd chart with POD_NAMES: v1 missing env
2 parents eae0e9e + 40e0cf0 commit 1331953

File tree

3 files changed

+30
-22
lines changed

3 files changed

+30
-22
lines changed

charts/in-clustercd/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
name: devtron-in-clustercd
22
description: Helm chart to deploy devtron-in-clustercd to run pre and post deployment in application/target cluster.
3-
version: 0.10.1
3+
version: 0.10.2
44
appVersion: 0.1.0
55
apiVersion: v1
66
maintainers:
77
88
name: Devtron Devops Team
99
10-
name: Ajay
10+
name: Ajay

charts/in-clustercd/templates/deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,9 @@ spec:
2525
fieldRef:
2626
apiVersion: v1
2727
fieldPath: metadata.name
28+
{{- with .Values.workflow.additionalWorkflowEnv }}
29+
{{- toYaml . | nindent 8 }}
30+
{{- end }}
2831
image: {{ .Values.workflow.image }}
2932
name: workflow-controller
3033
resources:

charts/in-clustercd/values.yaml

Lines changed: 25 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,31 @@
44

55
# Configuration for workflow-controller
66
workflow:
7-
config:
8-
parallelism: 50
9-
artifactRepository:
10-
archiveLogs: true
11-
instanceID: devtron-runner
12-
s3:
13-
endpoint: s3.amazonaws.com
14-
bucket: devtron-logs-test
15-
region: us-east-1
16-
keyFormat: "logs-v1/{{workflow.name}}"
17-
#keep it uncommented if logs will pushing through AWS node role permission(recommended)
18-
# accessKeySecret:
19-
# name: workflow-minio-cred
20-
# key: accessKey
21-
# secretKeySecret:
22-
# name: workflow-minio-cred
23-
# key: secretKey
24-
containerRuntimeExecutor: pns
25-
executor:
26-
imagePullPolicy: Always
7+
config: {}
8+
# parallelism: 50
9+
# artifactRepository:
10+
# archiveLogs: true
11+
# instanceID: devtron-runner
12+
# s3:
13+
# endpoint: s3.amazonaws.com
14+
# bucket: devtron-logs-test
15+
# region: us-east-1
16+
# keyFormat: "logs-v1/{{workflow.name}}"
17+
# # keep it uncommented if logs will pushing through AWS node role permission(recommended)
18+
# accessKeySecret:
19+
# name: workflow-minio-cred
20+
# key: accessKey
21+
# secretKeySecret:
22+
# name: workflow-minio-cred
23+
# key: secretKey
24+
# containerRuntimeExecutor: pns
25+
# executor:
26+
# imagePullPolicy: Always
27+
# # specify additional env for workflow-controller
28+
additionalWorkflowEnv : []
29+
# For example we can pass the env as below
30+
# - name: POD_NAMES
31+
# value: "v1"
2732

2833
# Access key and Secret key of AWS account to push logs to above S3 bucket if not provided it will use node role.
2934
use_access_secret_key: false

0 commit comments

Comments
 (0)