Skip to content

Commit 0aa8b5e

Browse files
committed
chore: css fixes
1 parent 137dd6e commit 0aa8b5e

File tree

3 files changed

+30
-33
lines changed

3 files changed

+30
-33
lines changed

src/components/charts/ChartCard.tsx

Lines changed: 26 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -93,19 +93,17 @@ const ChartCard = ({
9393
)
9494

9595
const renderIcon = () => (
96-
<div className={`${isListView ? 'flex' : 'px-20 pt-16 pb-12'}`}>
97-
<div className="icon-wrapper">
98-
<LazyImage
99-
className={`${isListView ? 'dc__list-icon' : ''} dc__chart-grid-item__icon chart-icon-dim br-4`}
100-
src={chart.icon}
101-
onError={handleImageError}
102-
/>
103-
</div>
96+
<div className="icon-wrapper">
97+
<LazyImage
98+
className={`${isListView ? 'dc__list-icon' : ''} dc__chart-grid-item__icon chart-icon-dim br-4`}
99+
src={chart.icon}
100+
onError={handleImageError}
101+
/>
104102
</div>
105103
)
106104

107105
const renderCardInfo = () => (
108-
<div className={`flexbox-col flex-grow-1 dc__gap-8 pb-16 ${isListView ? 'pt-20' : 'px-20'}`}>
106+
<div className="flexbox-col flex-grow-1 dc__gap-8">
109107
<div className="flexbox-col dc__gap-2">
110108
<div className="flex left">
111109
<InteractiveCellText
@@ -146,28 +144,26 @@ const ChartCard = ({
146144
onClick={onClick ? onClickChartSelect : noop}
147145
data-testid={`chart-card-${dataTestId}`}
148146
>
149-
<div className={`${isListView ? 'dc__grid chart-list-item px-20 dc__gap-16' : 'h-164'}`}>
147+
<div
148+
className={`${isListView ? 'dc__grid chart-list-item dc__gap-16' : 'flexbox-col h-166 dc__gap-12'} px-20 pt-20 pb-16`}
149+
>
150150
{renderIcon()}
151-
<div className={`${isListView ? 'dc__gap-16' : ''}`}>
152-
{serverMode === SERVER_MODE.FULL && addChart && subtractChart && (
153-
<div
154-
className={`devtron-stepper ${selectedCount > 0 ? 'dc__grid devtron-stepper-grid dc__border br-6 fw-6 cursor bg__primary' : ''}`}
155-
>
156-
{selectedCount > 0 && (
157-
<>
158-
{renderRemoveIcon()}
159-
160-
<span className="devtron-stepper__item fs-13 icon-dim-20 px-4">
161-
{selectedCount}
162-
</span>
163-
</>
164-
)}
165-
166-
{renderAddIcon()}
167-
</div>
168-
)}
169-
{renderCardInfo()}
170-
</div>
151+
{serverMode === SERVER_MODE.FULL && addChart && subtractChart && (
152+
<div
153+
className={`devtron-stepper ${selectedCount > 0 ? 'dc__grid devtron-stepper-grid dc__border br-6 fw-6 cursor bg__primary' : ''}`}
154+
>
155+
{selectedCount > 0 && (
156+
<>
157+
{renderRemoveIcon()}
158+
159+
<span className="devtron-stepper__item fs-13 icon-dim-20 px-4">{selectedCount}</span>
160+
</>
161+
)}
162+
163+
{renderAddIcon()}
164+
</div>
165+
)}
166+
{renderCardInfo()}
171167
</div>
172168
{renderFooter()}
173169
</div>

src/components/charts/charts.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
border-radius: 8px;
3131
padding: 8px;
3232
width: fit-content;
33+
height: fit-content;
3334
}
3435

3536
.chart-icon-dim {
@@ -116,7 +117,7 @@
116117
margin-right: auto;
117118

118119
.chart-list-item{
119-
grid-template-columns: 48px 1fr 84px;
120+
grid-template-columns: 50px 1fr 84px;
120121
}
121122
}
122123
}

src/css/base.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3417,8 +3417,8 @@ button.anchor {
34173417
height: 132px;
34183418
}
34193419

3420-
.h-164 {
3421-
height: 164px;
3420+
.h-166 {
3421+
height: 166px;
34223422
}
34233423

34243424
.h-192 {

0 commit comments

Comments
 (0)