Skip to content

Commit 122c58e

Browse files
committed
feat: consolidate CSV export header constants and remove unused components
1 parent 669644b commit 122c58e

File tree

8 files changed

+13
-604
lines changed

8 files changed

+13
-604
lines changed

src/Pages/GlobalConfigurations/Authorization/PermissionGroups/List/ExportPermissionGroupsToCsv.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,9 @@
1616

1717
import { ExportToCsv } from '@devtron-labs/devtron-fe-common-lib'
1818

19-
import { GROUP_EXPORT_HEADER_ROW } from '../../../../../components/common/ExportToCsv/constants'
2019
import { useAuthorizationContext } from '../../AuthorizationProvider'
2120
import { getRoleFiltersToExport } from '../../utils'
22-
import { GROUP_EXPORT_HEADERS } from './constants'
21+
import { GROUP_EXPORT_HEADER_ROW, GROUP_EXPORT_HEADERS } from './constants'
2322
import { ExportPermissionGroupDataType, PermissionGroupListHeaderProps } from './types'
2423

2524
const ExportPermissionGroupsToCsv = ({

src/Pages/GlobalConfigurations/Authorization/PermissionGroups/List/constants.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,3 +43,14 @@ export const GROUP_EXPORT_HEADERS: ExportToCsvProps<keyof ExportPermissionGroupD
4343
{ label: 'Application', key: 'application' },
4444
{ label: 'Role', key: 'role' },
4545
]
46+
47+
export const GROUP_EXPORT_HEADER_ROW = {
48+
groupName: 'Group Name',
49+
groupId: 'Group ID',
50+
description: 'Description',
51+
superAdmin: 'Super admin',
52+
project: 'Project',
53+
environment: 'Environment',
54+
application: 'Application',
55+
role: 'Role',
56+
}

src/Pages/GlobalConfigurations/Authorization/UserPermissions/List/ExportUserPermissionsToCsv.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,10 @@ import { useState } from 'react'
1919
import { ExportToCsv, ExportToCsvProps, getFormattedUTCTimeForExport } from '@devtron-labs/devtron-fe-common-lib'
2020

2121
import { importComponentFromFELibrary } from '../../../../../components/common'
22-
import { USER_EXPORT_HEADER_ROW } from '../../../../../components/common/ExportToCsv/constants'
2322
import { useAuthorizationContext } from '../../AuthorizationProvider'
2423
import { getRoleFiltersToExport } from '../../utils'
2524
import { LAST_LOGIN_TIME_NULL_STATE } from '../constants'
26-
import { USER_EXPORT_HEADERS } from './constants'
25+
import { USER_EXPORT_HEADER_ROW, USER_EXPORT_HEADERS } from './constants'
2726
import ExportConfigurationDialog from './ExportConfigurationDialog'
2827
import { ExportConfigurationDialogProps, ExportUserPermissionCSVDataType, UserPermissionListHeaderProps } from './types'
2928

src/components/common/ExportToCsv/ExportConfiguration.tsx

Lines changed: 0 additions & 81 deletions
This file was deleted.

0 commit comments

Comments
 (0)