Merge pull request #2568 from devtron-labs/fix/use-tabs

chore: use fallbackTabIndex prop instead of FALLBACK_TAB const in useTabs

Author: Elessar1802

package.json

@@ -4,7 +4,7 @@
     "private": true,
     "homepage": "/dashboard",
     "dependencies": {
-        "@devtron-labs/devtron-fe-common-lib": "1.9.5",
+        "@devtron-labs/devtron-fe-common-lib": "1.9.6",
         "@esbuild-plugins/node-globals-polyfill": "0.2.3",
         "@rjsf/core": "^5.13.3",
         "@rjsf/utils": "^5.13.3",

src/components/common/DynamicTabs/useTabs.ts

@@ -215,7 +215,7 @@ export function useTabs(persistenceKey: string, fallbackTabIndex = FALLBACK_TAB)
                 })
             }
             if (!_tabs.some((_tab) => _tab.isSelected)) {
-                _tabs[FALLBACK_TAB].isSelected = true
+                _tabs[fallbackTabIndex].isSelected = true
             }
 
             _tabs.sort((a, b) => {

src/components/workflowEditor/nodes/CDNode.tsx

@@ -387,7 +387,7 @@ export class CDNode extends Component<CDNodeProps, CDNodeState> {
                                         showAriaLabelInTippy
                                         onClick={this.handleDeleteCDNode}
                                         style={ButtonStyleType.negativeGrey}
-                                        icon={<Icon name="ic-delete" color={null} strokeWidth={1} size={12} />}
+                                        icon={<Icon name="ic-delete" color={null} size={12} />}
                                         showTooltip
                                         tooltipProps={{
                                             placement: 'right',

yarn.lock

@@ -1105,10 +1105,10 @@
   dependencies:
     "@jridgewell/trace-mapping" "0.3.9"
 
-"@devtron-labs/[email protected].5":
-  version "1.9.5"
-  resolved "https://registry.yarnpkg.com/@devtron-labs/devtron-fe-common-lib/-/devtron-fe-common-lib-1.9.5.tgz#e502d8a9de7eca925485127673b287be5ec31f68"
-  integrity sha512-G+OZEumMAHFe5RkCgVUVU42sqBE+IUMRetqaU5R6UWZmG2ILyUK/QcjYqBj0jduz8IMN7whhlFo85IIy6e6jEA==
+"@devtron-labs/[email protected].6":
+  version "1.9.6"
+  resolved "https://registry.yarnpkg.com/@devtron-labs/devtron-fe-common-lib/-/devtron-fe-common-lib-1.9.6.tgz#38c898e1a3d34d21740c82440700ab1c2b648b54"
+  integrity sha512-PT+3fF//TTsVO+2219dYgk7QNj1iA2/bBF+71UuAtZWYR5g4LhQQHaiDK281WqoawCF1KBHyPBy4xPhk9AaShQ==
   dependencies:
     "@codemirror/lang-json" "6.0.1"
     "@codemirror/lang-yaml" "6.1.2"