Skip to content

Commit 24f47a6

Browse files
committed
refactor: remove outdated chart details files
1 parent b9723d0 commit 24f47a6

File tree

14 files changed

+25
-1770
lines changed

14 files changed

+25
-1770
lines changed

.eslintignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,10 @@ src/components/charts/ChartGroupUpdate.tsx
143143
src/components/charts/ChartHeaderFilters.tsx
144144
src/components/charts/Charts.tsx
145145
src/components/charts/MultiChartSummary.tsx
146-
src/components/charts/SavedValues/SavedValuesList.tsx
147146
src/components/charts/chartValues/ChartValues.tsx
148147
src/components/charts/charts.service.ts
149148
src/components/charts/charts.util.tsx
150149
src/components/charts/dialogs/ValuesYamlConfirmDialog.tsx
151-
src/components/charts/discoverChartDetail/About.tsx
152-
src/components/charts/discoverChartDetail/ChartDeploymentList.tsx
153-
src/components/charts/discoverChartDetail/DiscoverChartDetails.tsx
154150
src/components/charts/list/ChartGroup.tsx
155151
src/components/charts/list/ChartListPopUp.tsx
156152
src/components/charts/list/ChartListPopUpRow.tsx

src/Pages/ChartStore/ChartDetails/ChartDetailsPresetValues.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import {
1616
} from '@devtron-labs/devtron-fe-common-lib'
1717

1818
import { deleteChartValues } from '@Components/charts/charts.service'
19-
import { SavedValueType } from '@Components/charts/SavedValues/types'
2019
import { URLS } from '@Config/routes'
2120
import { ApplicationDeletionInfo } from '@Pages/Shared/ApplicationDeletionInfo/ApplicationDeletionInfo'
2221

@@ -28,9 +27,9 @@ import {
2827
import { fetchChartValuesTemplateList } from './services'
2928
import {
3029
ChartDetailsRouteParams,
30+
ChartValuesTemplateDTO,
3131
PresetValuesTableAdditionalProps,
3232
PresetValuesTableProps,
33-
PresetValuesTableRowData,
3433
} from './types'
3534

3635
const renderEmptyStateButton = (path: string) => () => (
@@ -47,7 +46,7 @@ const renderEmptyStateButton = (path: string) => () => (
4746

4847
export const ChartDetailsPresetValues = () => {
4948
// STATES
50-
const [deletePresetValue, setDeletePresetValue] = useState<SavedValueType | null>(null)
49+
const [deletePresetValue, setDeletePresetValue] = useState<ChartValuesTemplateDTO | null>(null)
5150

5251
// HOOKS
5352
const {
@@ -102,7 +101,7 @@ export const ChartDetailsPresetValues = () => {
102101
reload: reloadChartValuesTemplateList,
103102
}}
104103
>
105-
<Table<PresetValuesTableRowData, FiltersTypeEnum.STATE, PresetValuesTableAdditionalProps>
104+
<Table<ChartValuesTemplateDTO, FiltersTypeEnum.STATE, PresetValuesTableAdditionalProps>
106105
id="table__chart-details-preset-values"
107106
loading={isFetchingChartValuesTemplateList}
108107
columns={PRESET_VALUES_TABLE_COLUMNS}

src/Pages/ChartStore/ChartDetails/services.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,12 @@ import {
99
import {
1010
deleteInstalledChart,
1111
getChartValuesCategorizedListParsed,
12-
getChartValuesTemplateList,
1312
getChartVersionDetails,
1413
getChartVersionsMin,
1514
} from '@Components/charts/charts.service'
1615
import { DELETE_ACTION, Routes } from '@Config/constants'
1716

18-
import { ChartDeploymentsDTO } from './types'
17+
import { ChartDeploymentsDTO, ChartValuesTemplateDTO } from './types'
1918

2019
export const fetchChartVersions = async (chartId: string) => {
2120
try {
@@ -59,7 +58,9 @@ export const fetchChartValuesList = async (chartId: string) => {
5958

6059
export const fetchChartValuesTemplateList = async (chartId: string) => {
6160
try {
62-
const { result } = await getChartValuesTemplateList(chartId)
61+
const { result } = await get<ChartValuesTemplateDTO[]>(
62+
`${Routes.CHART_STORE}/${Routes.CHART_STORE_VALUES}/${Routes.CHART_VALUES_LIST_TEMPLATE}/${chartId}`,
63+
)
6364
return result || []
6465
} catch (err) {
6566
showError(err)

src/Pages/ChartStore/ChartDetails/types.ts

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import {
1010
} from '@devtron-labs/devtron-fe-common-lib'
1111

1212
import { Chart, ChartDetailsDTO } from '@Components/charts/charts.types'
13-
import { SavedValueType } from '@Components/charts/SavedValues/types'
1413

1514
export type ChartSelectorOptionType = SelectPickerOptionType & Chart
1615

@@ -53,32 +52,38 @@ export interface ChartDetailsDeployProps
5352
}[]
5453
}
5554

56-
export type PresetValuesTableRowData = Omit<SavedValueType, 'isLoading'>
55+
export interface ChartValuesTemplateDTO {
56+
id: number
57+
name: string
58+
chartVersion: string
59+
updatedBy: string
60+
updatedOn: string
61+
}
5762

5863
export type PresetValuesTableAdditionalProps = {
59-
chartValuesTemplateList: SavedValueType[]
60-
showDeleteModal: (deletePresetValue: PresetValuesTableRowData) => () => void
64+
chartValuesTemplateList: ChartValuesTemplateDTO[]
65+
showDeleteModal: (deletePresetValue: ChartValuesTemplateDTO) => () => void
6166
}
6267

6368
export type PresetValuesTableProps = TableProps<
64-
PresetValuesTableRowData,
69+
ChartValuesTemplateDTO,
6570
FiltersTypeEnum.STATE,
6671
PresetValuesTableAdditionalProps
6772
>
6873

6974
export type PresetValuesTableCellComponentProps = TableCellComponentProps<
70-
PresetValuesTableRowData,
75+
ChartValuesTemplateDTO,
7176
FiltersTypeEnum.STATE,
7277
PresetValuesTableAdditionalProps
7378
>
7479

7580
export type PresetValuesTableRowActionsOnHoverComponentProps = TableRowActionsOnHoverComponentProps<
76-
PresetValuesTableRowData,
81+
ChartValuesTemplateDTO,
7782
PresetValuesTableAdditionalProps
7883
>
7984

8085
export type PresetValuesTableViewWrapperProps = TableViewWrapperProps<
81-
PresetValuesTableRowData,
86+
ChartValuesTemplateDTO,
8287
FiltersTypeEnum.STATE,
8388
PresetValuesTableAdditionalProps
8489
>

0 commit comments

Comments
 (0)