ignore normal close events of terminal

Mukul Tayal · Mukul Tayal · commit 281baf8e302f · 2024-02-12T22:19:39.000+05:30
diff --git a/src/components/terminal/TerminalWrapper.tsx b/src/components/terminal/TerminalWrapper.tsx
@@ -258,7 +258,7 @@ export class TerminalView extends Component<TerminalViewProps, TerminalViewState
         }
 
         socket.onclose = function (evt) {
-            if (window._env_.LOG_TERMINAL_EVENTS_TO_SENTRY) logExceptionToSentry(evt)
+            if (window._env_.LOG_TERMINAL_EVENTS_TO_SENTRY && evt.reason !== 'Normal closure') logExceptionToSentry(evt)
             setSocketConnection('DISCONNECTED')
         }
 
diff --git a/src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/Terminal.tsx b/src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/terminal/Terminal.tsx
@@ -179,7 +179,7 @@ export default function TerminalView({
         }
 
         _socket.onclose = function (evt) {
-            if (window._env_.LOG_TERMINAL_EVENTS_TO_SENTRY) logExceptionToSentry(evt)
+            if (window._env_.LOG_TERMINAL_EVENTS_TO_SENTRY && evt.reason !== 'Normal closure') logExceptionToSentry(evt)
             disableInput()
             _terminal.writeln('')
             _terminal.writeln('---------------------------------------------')

Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ export class TerminalView extends Component<TerminalViewProps, TerminalViewState`
`258`	`258`	`}`
`259`	`259`
`260`	`260`	`socket.onclose = function (evt) {`
`261`		`- if (window._env_.LOG_TERMINAL_EVENTS_TO_SENTRY) logExceptionToSentry(evt)`
	`261`	`+ if (window._env_.LOG_TERMINAL_EVENTS_TO_SENTRY && evt.reason !== 'Normal closure') logExceptionToSentry(evt)`
`262`	`262`	`setSocketConnection('DISCONNECTED')`
`263`	`263`	`}`
`264`	`264`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,7 @@ export default function TerminalView({`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`_socket.onclose = function (evt) {`
`182`		`- if (window._env_.LOG_TERMINAL_EVENTS_TO_SENTRY) logExceptionToSentry(evt)`
	`182`	`+ if (window._env_.LOG_TERMINAL_EVENTS_TO_SENTRY && evt.reason !== 'Normal closure') logExceptionToSentry(evt)`
`183`	`183`	`disableInput()`
`184`	`184`	`_terminal.writeln('')`
`185`	`185`	`_terminal.writeln('---------------------------------------------')`