fix: review comments

Author: AbhishekA1509

src/components/app/details/triggerView/BuildImageModal/BulkBuildImageModal.tsx

@@ -27,7 +27,6 @@ import {
     WorkflowType,
 } from '@devtron-labs/devtron-fe-common-lib'
 
-import { ReactComponent as MechanicalOperation } from '@Images/ic-mechanical-operation.svg'
 import { BulkCIDetailType, ResponseRowType } from '@Components/ApplicationGroup/AppGroup.types'
 import {
     BULK_CI_BUILD_STATUS,
@@ -417,7 +416,7 @@ const BulkBuildImageModal = ({
                 ? BULK_CI_BUILD_STATUS(numberOfAppsLoading)
                 : BULK_CI_MATERIAL_STATUS(numberOfAppsLoading)
 
-            return <GenericEmptyState {...message} SvgImage={MechanicalOperation} contentClassName="text-center" />
+            return <GenericEmptyState {...message} imgName="img-mechanical-operation" contentClassName="text-center" />
         }
 
         if (isLoadingSingleAppInfoMap) {

src/components/app/details/triggerView/DeployImageModal/BulkDeployEmptyState.tsx

@@ -27,7 +27,7 @@ const BulkDeployEmptyState = ({
         return <TriggerBlockEmptyState stageType={stageType} appId={appId} />
     }
 
-    if (isTriggerBlockedDueToPlugin) {
+    if (MissingPluginBlockState && isTriggerBlockedDueToPlugin) {
         // It can't be CD
         const commonNodeAttrType: CommonNodeAttr['type'] = stageType === DeploymentNodeType.PRECD ? 'PRECD' : 'POSTCD'
 

src/components/app/details/triggerView/DeployImageModal/BulkDeployModal.tsx

@@ -29,7 +29,6 @@ import {
     useMainContext,
 } from '@devtron-labs/devtron-fe-common-lib'
 
-import { ReactComponent as MechanicalOperation } from '@Images/ic-mechanical-operation.svg'
 import { ResponseRowType } from '@Components/ApplicationGroup/AppGroup.types'
 import {
     BULK_CD_DEPLOYMENT_STATUS,
@@ -569,7 +568,7 @@ const BulkDeployModal = ({ handleClose, stageType, workflows, isVirtualEnvironme
 
             return (
                 <GenericEmptyState
-                    SvgImage={MechanicalOperation}
+                    imgName="img-mechanical-operation"
                     title={message.title}
                     subTitle={message.subTitle}
                     contentClassName="text-center"

src/components/app/details/triggerView/DeployImageModal/ImageSelectionCTA.tsx

@@ -112,7 +112,7 @@ const ImageSelectionCTA = ({
 
                     {material.filterState !== FilterStates.ALLOWED && (
                         <div className="flex dc__gap-12 mr-12">
-                            <div className="h-12 dc__border-left" />
+                            <div className="dc__divider h12" />
                         </div>
                     )}
                 </>

src/components/app/details/triggerView/DeployImageModal/MaterialListEmptyState.tsx

@@ -3,6 +3,7 @@ import {
     ButtonVariantType,
     EMPTY_STATE_STATUS,
     GenericEmptyState,
+    GenericFilterEmptyState,
     getIsApprovalPolicyConfigured,
 } from '@devtron-labs/devtron-fe-common-lib'
 
@@ -49,12 +50,6 @@ const MaterialListEmptyState = ({
         onSearchApply('')
     }
 
-    const renderGenerateButton = () => (
-        <button className="flex cta h-32" onClick={clearSearch} type="button">
-            Clear filter
-        </button>
-    )
-
     const renderFilterEmptyStateSubtitle = (): JSX.Element => (
         <p className="m-0 flex cn-8 fs-13 fw-4 lh-20">
             <button
@@ -118,12 +113,10 @@ const MaterialListEmptyState = ({
 
     if (isSearchApplied) {
         return (
-            <GenericEmptyState
-                image={noArtifact}
+            <GenericFilterEmptyState
+                handleClearFilters={clearSearch}
                 title="No matching image available"
                 subTitle="We couldn't find any matching image"
-                isButtonAvailable
-                renderButton={renderGenerateButton}
             />
         )
     }