Skip to content

Commit 36d320a

Browse files
committed
Merge branch 'develop' of github.com:devtron-labs/dashboard into feat/notifications
2 parents 0bb143e + c6b3040 commit 36d320a

File tree

58 files changed

+1356
-942
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+1356
-942
lines changed

.eslintignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ src/components/common/helpers/Helpers.tsx
296296
src/components/common/helpers/compareVersion.ts
297297
src/components/common/helpers/isSubset.ts
298298
src/components/common/helpers/time.ts
299-
src/components/common/helpers/util.ts
299+
src/components/common/helpers/utils.tsx
300300
src/components/common/helpers/workflowURL.ts
301301
src/components/common/hooks/FileReader.ts
302302
src/components/common/hooks/__tests__/FileReader.test.tsx

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"homepage": "/dashboard",
66
"dependencies": {
7-
"@devtron-labs/devtron-fe-common-lib": "0.3.4",
7+
"@devtron-labs/devtron-fe-common-lib": "0.3.6",
88
"@esbuild-plugins/node-globals-polyfill": "0.2.3",
99
"@rjsf/core": "^5.13.3",
1010
"@rjsf/utils": "^5.13.3",

src/Pages/Applications/DevtronApps/Details/AppConfigurations/AppConfig.types.ts

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,7 @@ export interface ExtendedCollapsibleListItem
241241
configState: ResourceConfigState
242242
}
243243

244+
// DEPLOYMENT CONFIG COMPARE INTERFACES & TYPES ------- START
244245
export interface DeploymentConfigParams {
245246
appId: string
246247
envId: string
@@ -276,6 +277,8 @@ export enum AppEnvDeploymentConfigQueryParams {
276277
COMPARE_WITH_IDENTIFIER_ID = 'compareWithIdentifierId',
277278
COMPARE_WITH_PIPELINE_ID = 'compareWithPipelineId',
278279
CHART_REF_ID = 'chartRefId',
280+
MANIFEST_CHART_REF_ID = 'manifestChartRefId',
281+
COMPARE_WITH_MANIFEST_CHART_REF_ID = 'compareWithManifestChartRefId',
279282
}
280283

281284
export interface AppEnvDeploymentConfigQueryParamsType {
@@ -287,4 +290,29 @@ export interface AppEnvDeploymentConfigQueryParamsType {
287290
compareWithIdentifierId?: number
288291
compareWithPipelineId?: number
289292
chartRefId?: number
293+
manifestChartRefId?: number
294+
compareWithManifestChartRefId?: number
290295
}
296+
297+
export type GetConfigDiffDataProps = Required<
298+
Pick<DeploymentConfigCompareProps, 'appName' | 'envName' | 'type'> & {
299+
configType: AppEnvDeploymentConfigType
300+
compareName: string
301+
identifierId: number
302+
pipelineId: number
303+
}
304+
>
305+
306+
export type GetDeploymentTemplateDataProps = Omit<GetConfigDiffDataProps, 'identifierId' | 'pipelineId'>
307+
308+
export type GetManifestDataProps = Pick<DeploymentConfigCompareProps, 'type' | 'environments'> & {
309+
appId: string
310+
envId: string
311+
configType: AppEnvDeploymentConfigType
312+
compareName: string
313+
values: string
314+
identifierId: number
315+
pipelineId: number
316+
manifestChartRefId: number
317+
}
318+
// DEPLOYMENT CONFIG COMPARE INTERFACES & TYPES ------- END

src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/AppComposeRouter.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,10 @@ const AppComposeRouter = () => {
302302
const envOverridePath = match.params.envId
303303
? `/${URLS.APP_ENV_OVERRIDE_CONFIG}/${match.params.envId}`
304304
: ''
305-
const resourceTypePath = `/${match.params.resourceType}`
305+
// Set the resourceTypePath based on the resourceType from the URL parameters.
306+
// If the resourceType is 'Manifest', use 'deployment-template' as the back URL.
307+
// Otherwise, use the actual resourceType from the URL, which could be 'deployment-template', 'configmap', or 'secrets'.
308+
const resourceTypePath = `/${match.params.resourceType === EnvResourceType.Manifest ? EnvResourceType.DeploymentTemplate : match.params.resourceType}`
306309
const resourceNamePath = match.params.resourceName
307310
? `/${match.params.resourceName}`
308311
: ''

0 commit comments

Comments
 (0)