refactor: move ResourceRecommenderTableCellComponent to fe-lib

Author: Elessar1802

src/components/ResourceBrowser/ResourceList/ResourceBrowserActionMenu.tsx

@@ -40,6 +40,7 @@ import { getShowResourceScanModal, importComponentFromFELibrary } from '../../co
 import { NodeType } from '../../v2/appDetails/appDetails.type'
 import { ResourceBrowserActionMenuType } from '../Types'
 import DeleteResourcePopup from './DeleteResourcePopup'
+import { ResourceBrowserActionMenuEnum } from './types'
 
 const getResourceScanDetails: ({
     name,
@@ -58,15 +59,6 @@ const getResourceScanDetails: ({
     'function',
 )
 
-enum ResourceBrowserActionMenuEnum {
-    manifest = 'manifest',
-    events = 'events',
-    logs = 'logs',
-    terminal = 'terminal',
-    delete = 'delete',
-    vulnerability = 'vulnerability',
-}
-
 const ResourceBrowserActionMenu = forwardRef(
     (
         {

src/components/ResourceBrowser/ResourceList/ResourceFilterOptions.tsx

@@ -170,7 +170,7 @@ const ResourceFilterOptions = ({
     const handleInputFocus = () => setIsInputFocused(true)
 
     const handleOnEventTypeChange: SegmentedControlProps['onChange'] = ({ value }) => {
-        updateSearchParams({ eventType: value })
+        updateSearchParams({ eventType: value === 'normal' ? value : null })
     }
 
     const handleToggleShowAbsoluteValues = () => {

src/components/ResourceBrowser/ResourceList/ResourceList.tsx

@@ -64,9 +64,8 @@ import NodeDetailComponentWrapper from './NodeDetailComponentWrapper'
 import NodeDetailWrapper from './NodeDetailWrapper'
 import { renderRefreshBar } from './ResourceList.component'
 import ResourcePageHeader from './ResourcePageHeader'
-import ResourceRecommenderTableCellComponent from './ResourceRecommenderTableCellComponent'
 import { ResourceRecommenderTableViewWrapper } from './ResourceRecommenderTableViewWrapper'
-import { dynamicSort, getClusterOptions } from './utils'
+import { dynamicSort, getClusterOptions, getResourceRecommenderResourceDetailURL } from './utils'
 
 const MonitoringDashboard = importComponentFromFELibrary('MonitoringDashboard', null, 'function')
 const ResourceRecommender = importComponentFromFELibrary('ResourceRecommender', null, 'function')
@@ -370,8 +369,8 @@ const ResourceList = () => {
                     <DynamicTabComponentWrapper type="fixed" {...DynamicTabComponentWrapperBaseProps}>
                         <ResourceRecommender
                             selectedCluster={selectedCluster}
-                            ResourceRecommenderTableCellComponent={ResourceRecommenderTableCellComponent}
                             ResourceRecommenderTableViewWrapper={ResourceRecommenderTableViewWrapper}
+                            getResourceRecommenderResourceDetailURL={getResourceRecommenderResourceDetailURL}
                             dynamicSort={dynamicSort}
                         />
                     </DynamicTabComponentWrapper>

src/components/ResourceBrowser/ResourceList/ResourceRecommenderTableCellComponent.tsx

@@ -114,3 +114,12 @@ export enum NodeActionMenuOptionIdEnum {
     editYaml = 'edit-yaml',
     delete = 'delete',
 }
+
+export enum ResourceBrowserActionMenuEnum {
+    manifest = 'manifest',
+    events = 'events',
+    logs = 'logs',
+    terminal = 'terminal',
+    delete = 'delete',
+    vulnerability = 'vulnerability',
+}

src/components/ResourceBrowser/ResourceList/types.ts

@@ -14,21 +14,28 @@
  * limitations under the License.
  */
 
+import { MouseEvent } from 'react'
+import { generatePath } from 'react-router-dom'
+
 import {
+    ALL_NAMESPACE_OPTION,
     ClusterDetail,
     logExceptionToSentry,
     numberComparatorBySortOrder,
     stringComparatorBySortOrder,
     versionComparatorBySortOrder,
 } from '@devtron-labs/devtron-fe-common-lib'
 
+import { clusterId } from '@Components/ClusterNodes/__mocks__/clusterAbout.mock'
 import { importComponentFromFELibrary, k8sStyledAgeToSeconds, sortObjectArrayAlphabetically } from '@Components/common'
 import { UseTabsReturnType } from '@Components/common/DynamicTabs/types'
 
 import {
+    DUMMY_RESOURCE_GVK_VERSION,
     K8S_EMPTY_GROUP,
     NODE_K8S_VERSION_FILTER_KEY,
     NODE_SEARCH_KEYS_TO_OBJECT_KEYS,
+    RESOURCE_ACTION_MENU,
     RESOURCE_BROWSER_ROUTES,
     ResourceBrowserRouteToTabIdMap,
     SIDEBAR_KEYS,
@@ -323,3 +330,24 @@ export const getTabIdForTab = (
     const functionParams = getTabIdParamsForPath(path, params)
     return functionParams ? getTabId(...functionParams) : null
 }
+
+export const getResourceRecommenderResourceDetailURL = (e: MouseEvent<HTMLButtonElement>) => {
+    const {
+        name,
+        namespace = ALL_NAMESPACE_OPTION.value,
+        kind,
+        group: _group,
+        tab = RESOURCE_ACTION_MENU.manifest,
+    } = e.currentTarget.dataset
+
+    const url = generatePath(RESOURCE_BROWSER_ROUTES.K8S_RESOURCE_DETAIL, {
+        clusterId,
+        namespace,
+        name,
+        kind: kind.toLowerCase(),
+        group: _group || K8S_EMPTY_GROUP,
+        version: DUMMY_RESOURCE_GVK_VERSION,
+    })
+
+    return `${url}/${tab}`
+}