Skip to content

Commit 3aed947

Browse files
authored
Merge pull request #2563 from devtron-labs/fix/gitops-footer
fix: sticky footer for gitops and user gitops
2 parents ffe4178 + 81424c9 commit 3aed947

File tree

2 files changed

+23
-22
lines changed

2 files changed

+23
-22
lines changed

src/components/gitOps/GitOpsConfiguration.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1370,7 +1370,7 @@ class GitOpsConfiguration extends Component<GitOpsProps & { isFeatureUserDefined
13701370
const renderGitOpsBody = () => {
13711371
return (
13721372
<form className="flex column left w-100" autoComplete="off" onKeyDown={handleDisableSubmitOnEnter}>
1373-
<div className="pb-64 flex left column dc__gap-16 w-100 dc__mxw-1000">
1373+
<div className="flex left column dc__gap-16 w-100 dc__mxw-1000">
13741374
{renderGitOpsTabs()}
13751375
{renderGitOpsFormInputs()}
13761376
{renderTLSConfigForm()}
@@ -1382,7 +1382,7 @@ class GitOpsConfiguration extends Component<GitOpsProps & { isFeatureUserDefined
13821382

13831383
const renderGitOpsFooter = () => {
13841384
return (
1385-
<div className="form__buttons flex left dc__position-fixed bg__primary w-100 dc__bottom-0 px-20 py-16 dc__border-top-n1">
1385+
<div className="flex left bg__primary w-100 px-20 py-16 dc__border-top-n1">
13861386
<button
13871387
type="submit"
13881388
disabled={this.state.saveLoading}
@@ -1406,9 +1406,9 @@ class GitOpsConfiguration extends Component<GitOpsProps & { isFeatureUserDefined
14061406
}
14071407

14081408
return (
1409-
<div className="bg__primary flex-grow-1 w-100 h-100">
1410-
<section className="flex-1 bg__primary flex left column">
1411-
<div className="flex left column px-20 py-16 dc__gap-24 w-100">
1409+
<div className="bg__primary flex-grow-1 w-100 h-100 flexbox-col dc__overflow-auto">
1410+
<section className="flex-1 bg__primary flex left column flexbox-col dc__overflow-auto dc__content-space">
1411+
<div className="flex left column px-20 py-16 dc__gap-24 w-100 dc__overflow-auto flex-grow-1">
14121412
<FeatureTitleWithInfo
14131413
title={HEADER_TEXT.GITOPS.title}
14141414
renderDescriptionContent={() => HEADER_TEXT.GITOPS.description}

src/components/gitOps/UserGitRepConfiguration.tsx

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -137,26 +137,27 @@ const UserGitRepConfiguration: FunctionComponent<UserGitRepoConfigurationProps>
137137
}
138138

139139
return (
140-
<div className="w-100 h-100 bg__primary pt-16 flexbox-col">
141-
<div className="w-960">
142-
<div className="fs-16 fcn-9 fw-6 ml-20 mb-8" data-testid="gitops-config-heading">
143-
GitOps Configuration
140+
<div className="w-100 h-100 bg__primary pt-16 flexbox-col flex-grow-1 dc__overflow-auto dc__content-space">
141+
<div className="flex-grow-1 dc__overflow-auto">
142+
<div className="w-960">
143+
<div className="fs-16 fcn-9 fw-6 ml-20 mb-8" data-testid="gitops-config-heading">
144+
GitOps Configuration
145+
</div>
146+
{isEditable ? (
147+
<UserGitRepo
148+
setSelectedRepoType={setSelectedRepoType}
149+
selectedRepoType={selectedRepoType}
150+
repoURL={gitOpsRepoURL}
151+
setRepoURL={setGitOpsRepoURL}
152+
authMode={authMode}
153+
/>
154+
) : (
155+
renderSavedGitOpsRepoState(gitOpsRepoURL)
156+
)}
144157
</div>
145-
{isEditable ? (
146-
<UserGitRepo
147-
setSelectedRepoType={setSelectedRepoType}
148-
selectedRepoType={selectedRepoType}
149-
repoURL={gitOpsRepoURL}
150-
setRepoURL={setGitOpsRepoURL}
151-
authMode={authMode}
152-
/>
153-
) : (
154-
renderSavedGitOpsRepoState(gitOpsRepoURL)
155-
)}
156158
</div>
157159
{isEditable && (
158-
<div className="pl-16 w-960">
159-
<hr />
160+
<div className="flex left w-100 px-20 py-16 dc__border-top-n1">
160161
<button
161162
data-testid="save_cluster_list_button_after_selection"
162163
className="cta h-36 lh-36 "

0 commit comments

Comments
 (0)