Skip to content

Commit 3d7206f

Browse files
committed
fix: review comments
1 parent 757e9c1 commit 3d7206f

File tree

5 files changed

+4
-12
lines changed

5 files changed

+4
-12
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"react-csv": "^2.2.2",
2929
"react-dates": "^21.8.0",
3030
"react-dom": "^17.0.2",
31-
"react-draggable": "^4.4.5",
3231
"react-ga4": "^1.4.1",
3332
"react-gtm-module": "^2.0.11",
3433
"react-mde": "^11.5.0",

src/components/app/details/main.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,6 @@ export default function AppDetailsPage() {
9494
const [apiError, setApiError] = useState(null)
9595
const [initLoading, setInitLoading] = useState<boolean>(false)
9696

97-
const { aiAgentContext } = useMainContext()
98-
99-
const parentRef = useRef<HTMLDivElement>(null)
100-
10197
const { fetchRecentlyVisitedParsedApps } = useUserPreferences({})
10298

10399
const getAppMetaInfoRes = async (shouldResetAppName: boolean = false): Promise<AppMetaInfo> => {
@@ -362,7 +358,7 @@ export default function AppDetailsPage() {
362358
const _filteredEnvIds = selectedAppList.length > 0 ? selectedAppList.map((app) => +app.value).join(',') : null
363359

364360
return (
365-
<div ref={parentRef} className="app-details-page flexbox-col w-100 h-100 dc__overflow-auto">
361+
<div className="app-details-page flexbox-col w-100 h-100 dc__overflow-auto">
366362
<AppHeader
367363
appName={appName}
368364
appMetaInfo={appMetaInfo}

src/components/common/SidePanel/SidePanelContent.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ export const SidePanelContent = ({ onClose, setSidePanelConfig, sidePanelConfig
9393

9494
return (
9595
<div
96+
key={id}
9697
role="button"
9798
data-testid={`side-panel-tab-${id}`}
9899
className={`flex dc__gap-6 dc__border-right px-16 dc__transition--background ${isSelected ? 'bg__primary' : ''}`}

src/components/common/SidePanel/types.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,9 @@ export interface SidePanelContentBaseProps {
1010
SidePanelHeaderActions: FunctionComponent
1111
}
1212

13-
export interface SidePanelContentProps {
13+
export interface SidePanelContentProps extends Pick<MainContext, 'sidePanelConfig' | 'setSidePanelConfig'> {
1414
tab?: SidePanelTab
1515
onClose: () => void
16-
setSidePanelConfig: MainContext['setSidePanelConfig']
17-
sidePanelConfig: MainContext['sidePanelConfig']
1816
}
1917

2018
export interface TabConfig {

src/components/common/navigation/NavigationRoutes.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,6 @@ export default function NavigationRoutes({ reloadVersionConfig }: Readonly<Navig
150150
const [environmentId, setEnvironmentId] = useState(null)
151151
const contextValue = useMemo(() => ({ environmentId, setEnvironmentId }), [environmentId])
152152

153-
const parentRef = useRef<HTMLDivElement>(null)
154-
155153
const { showThemeSwitcherDialog, handleThemeSwitcherDialogVisibilityChange, appTheme } = useTheme()
156154

157155
const [environmentDataState, setEnvironmentDataState] = useState<EnvironmentDataStateType>(INITIAL_ENV_DATA_STATE)
@@ -518,7 +516,7 @@ export default function NavigationRoutes({ reloadVersionConfig }: Readonly<Navig
518516
isFELibAvailable: !!isFELibAvailable,
519517
}}
520518
>
521-
<motion.main ref={parentRef} id={DEVTRON_BASE_MAIN_ID} style={{ gridTemplateColumns }}>
519+
<motion.main id={DEVTRON_BASE_MAIN_ID} style={{ gridTemplateColumns }}>
522520
{showThemeSwitcherDialog && (
523521
<SwitchThemeDialog
524522
initialThemePreference={userPreferences?.themePreference}

0 commit comments

Comments
 (0)