Skip to content

Commit 47252e3

Browse files
committed
removed: unnecessary conditions
1 parent 1bbc656 commit 47252e3

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

src/components/ApplicationGroup/Details/TriggerView/EnvTriggerView.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -993,12 +993,11 @@ export default function EnvTriggerView({ filteredAppIds, isVirtualEnv }: AppGrou
993993
return
994994
}
995995

996-
const _ciPipelineType = node.isExternal ? CIPipelineBuildType.CI_EXTERNAL : CIPipelineBuildType.CI_BUILD
997996
const payload = {
998997
pipelineId: +selectedCINode.id,
999998
ciPipelineMaterials: ciPipelineMaterials,
1000999
invalidateCache: invalidateCache,
1001-
pipelineType: node.isJobCI ? CIPipelineBuildType.CI_JOB : _ciPipelineType
1000+
pipelineType: node.isJobCI ? CIPipelineBuildType.CI_JOB : CIPipelineBuildType.CI_BUILD
10021001
}
10031002

10041003
triggerCINode(payload)

src/components/CIPipelineN/CIPipeline.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -521,8 +521,12 @@ export default function CIPipeline({
521521
_ciPipeline.environmentId = undefined
522522
}
523523
if (!isJobView) {
524-
const _ciPipelineType = ciPipeline.isExternal ? CIPipelineBuildType.CI_EXTERNAL : CIPipelineBuildType.CI_BUILD
525-
const ciPipelineType = isJobCI ? CIPipelineBuildType.CI_JOB : _ciPipelineType
524+
let ciPipelineType: CIPipelineBuildType = CIPipelineBuildType.CI_BUILD
525+
if (ciPipeline.isExternal) {
526+
ciPipelineType = CIPipelineBuildType.CI_EXTERNAL
527+
} else if (isJobCI) {
528+
ciPipelineType = CIPipelineBuildType.CI_JOB
529+
}
526530
_ciPipeline.pipelineType = ciPipeline.id ? ciPipeline.pipelineType : ciPipelineType
527531
}
528532
saveCIPipeline(

src/components/app/details/triggerView/TriggerView.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -921,13 +921,12 @@ class TriggerView extends Component<TriggerViewProps, TriggerViewState> {
921921
envId = this.state.selectedEnv.id
922922
}
923923

924-
const _ciPipelineType = node.isExternal ? CIPipelineBuildType.CI_EXTERNAL : CIPipelineBuildType.CI_BUILD
925924
const payload = {
926925
pipelineId: +this.state.ciNodeId,
927926
ciPipelineMaterials: ciPipelineMaterials,
928927
invalidateCache: this.state.invalidateCache,
929928
environmentId: envId,
930-
pipelineType: node.isJobCI ? CIPipelineBuildType.CI_JOB : _ciPipelineType
929+
pipelineType: node.isJobCI ? CIPipelineBuildType.CI_JOB : CIPipelineBuildType.CI_BUILD
931930
}
932931

933932
triggerCINode(payload)

0 commit comments

Comments
 (0)