Skip to content

Commit 48b2c4f

Browse files
authored
Merge pull request #2612 from devtron-labs/feat/anchor-support-in-button
feat: add support for anchor tag in Button component
2 parents a076ee4 + d468428 commit 48b2c4f

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"homepage": "/dashboard",
66
"dependencies": {
7-
"@devtron-labs/devtron-fe-common-lib": "1.10.6",
7+
"@devtron-labs/devtron-fe-common-lib": "1.10.8",
88
"@esbuild-plugins/node-globals-polyfill": "0.2.3",
99
"@rjsf/core": "^5.13.3",
1010
"@rjsf/utils": "^5.13.3",

src/stories/Button.stories.tsx

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ const linkProps: ButtonProps<ButtonComponentType.link>['linkProps'] = {
3434
target: '_blank',
3535
}
3636

37+
const anchorProps: ButtonProps<ButtonComponentType.anchor>['anchorProps'] = {
38+
href: 'https://www.devtron.ai',
39+
}
40+
3741
const meta = {
3842
component: Button,
3943
argTypes: {
@@ -67,6 +71,7 @@ const ButtonTemplate: Story = {
6771
style: ButtonStyleType.default,
6872
size: ComponentSizeType.large,
6973
linkProps,
74+
anchorProps,
7075
onClick: action('Button clicked'),
7176
disabled: false,
7277
isLoading: false,

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1126,10 +1126,10 @@
11261126
dependencies:
11271127
"@jridgewell/trace-mapping" "0.3.9"
11281128

1129-
"@devtron-labs/[email protected].6":
1130-
version "1.10.6"
1131-
resolved "https://registry.yarnpkg.com/@devtron-labs/devtron-fe-common-lib/-/devtron-fe-common-lib-1.10.6.tgz#bc3792c519cb9a00204ef29487b5c17809289f15"
1132-
integrity sha512-ZVZTfUpnEiqo2t+n+4n5cirGWkZeafSOJWxbmSVBHD5oqpt8yrD+UBrvDxy1viTwOCrjwol6dkVllNEZeA3V3A==
1129+
"@devtron-labs/[email protected].8":
1130+
version "1.10.8"
1131+
resolved "https://registry.yarnpkg.com/@devtron-labs/devtron-fe-common-lib/-/devtron-fe-common-lib-1.10.8.tgz#6a182b39e222a9dc980156de090726e0bab07467"
1132+
integrity sha512-vg3VMfTFt0ak08J0FnhtfAIiD0u+0c2n0dFNuuPeJuCY3SIDBNM3CEgYrwq3KQtRrkbiNNyBONJuA3FY8rOzsw==
11331133
dependencies:
11341134
"@codemirror/lang-json" "6.0.1"
11351135
"@codemirror/lang-yaml" "6.1.2"

0 commit comments

Comments
 (0)