PR comments and disable download for nor prev container

Author: Mukul Tayal

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/Logs.component.tsx

@@ -127,13 +127,6 @@ function LogsComponent({
         setPrevContainer(false)
     }
 
-    const handleLogsShown = (option) => {
-        setLogsShownOption({
-            prev: logsShownOption.current,
-            current: option,
-        })
-    }
-
     const handleSearchTextChange = (searchText: string) => {
         if (!searchText) {
             setLogState({
@@ -365,6 +358,18 @@ function LogsComponent({
         }
     }
 
+    const handleLogOptionChange = (selected) => {
+        setLogsShownOption({
+            prev: logsShownOption.current,
+            current: selected,
+        })
+        if (selected.value !== CUSTOM_LOGS_FILTER.CUSTOM) {
+            setNewFilteredLogs(true)
+        } else {
+            setShowCustomOptionsMoadal(true)
+        }
+    }
+
     useEffect(() => {
         logsPausedRef.current = logsPaused
     }, [logsPaused])
@@ -662,14 +667,7 @@ function LogsComponent({
                         <LinesIcon className="icon-dim-16 mr-8" />
                         <Select
                             options={getPodLogsOptions()}
-                            onChange={(selected) => {
-                                handleLogsShown(selected)
-                                if (selected.value !== CUSTOM_LOGS_FILTER.CUSTOM) {
-                                    setNewFilteredLogs(true)
-                                } else {
-                                    setShowCustomOptionsMoadal(true)
-                                }
-                            }}
+                            onChange={handleLogOptionChange}
                             value={logsShownOption.current}
                             styles={{
                                 ...multiSelectStyles,
@@ -690,9 +688,10 @@ function LogsComponent({
                             <Tippy className="default-tt" arrow={false} placement="top" content={'Download logs'}>
                                 <Download
                                     className={`icon-dim-16 mr-8 cursor ${
-                                        (podContainerOptions?.containerOptions ?? []).length > 0
-                                            ? ''
-                                            : 'cursor-not-allowed dc__opacity-0_5'
+                                        (podContainerOptions?.containerOptions ?? []).length === 0 ||
+                                        (prevContainer && showNoPrevContainer != '')
+                                            ? 'cursor-not-allowed dc__opacity-0_5'
+                                            : ''
                                     }`}
                                     onClick={handleDownloadLogs}
                                 />

src/components/v2/appDetails/k8Resource/nodeDetail/nodeDetail.api.ts

@@ -229,6 +229,7 @@ export const getLogsURL = (
     clusterId?: number,
     namespace?: string,
 ) => {
+    //similar logic exists in downloadLogs function also, recheck changes there also or extract this logic in a common function
     let filter = ''
     if (logsOption.value === CUSTOM_LOGS_FILTER.CUSTOM) {
         filter = getFilterWithValue(customOption.option, customOption.value, customOption.unit)

src/components/v2/appDetails/k8Resource/nodeDetail/nodeDetail.util.ts

@@ -350,14 +350,16 @@ export const excludeFutureTimingsOptions = (allOptions, index) => {
 }
 
 export const getTimeFromTimestamp = (timestamp) => {
-const date = new Date(+timestamp * 1000); 
-const hours = date.getHours();
-const minutes = date.getMinutes();
-const seconds = date.getSeconds();
-const value= `${hours.toString().padStart(2, '0')}:${minutes.toString().padStart(2, '0')}:${seconds.toString().padStart(2, '0')}`
-return ALLOW_UNTIL_TIME_OPTIONS.filter((option) => {
-    return option.value == value
-})
+    const date = new Date(+timestamp * 1000)
+    const hours = date.getHours()
+    const minutes = date.getMinutes()
+    const seconds = date.getSeconds()
+    const value = `${hours.toString().padStart(2, '0')}:${minutes.toString().padStart(2, '0')}:${seconds
+        .toString()
+        .padStart(2, '0')}`
+    return ALLOW_UNTIL_TIME_OPTIONS.filter((option) => {
+        return option.value == value
+    })
 }
 
 export const getDurationUnits = () => [