Skip to content

Commit 4f43f76

Browse files
committed
chore: sonar fixes
1 parent 9fe0f32 commit 4f43f76

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

src/components/ApplicationGroup/Details/TriggerView/EnvTriggerView.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ import BulkSourceChange from './BulkSourceChange'
7979
import { getSelectedNodeAndAppId } from './utils'
8080

8181
import './EnvTriggerView.scss'
82-
import { ActionMenuItemIconType } from '.yalc/@devtron-labs/devtron-fe-common-lib/dist/Shared/Components/TrailingItem'
8382
import { EnvTriggerViewActionKey } from './types'
8483

8584
const ApprovalMaterialModal = importComponentFromFELibrary('ApprovalMaterialModal')

src/components/ResourceBrowser/ResourceList/ClusterSelector.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,12 +144,8 @@ const ClusterSelector: React.FC<ClusterSelectorType> = ({
144144
const handleActionMenuClick: ActionMenuProps['onClick'] = (
145145
item: ActionMenuItemType<ClusterActionMenuOptionIdEnum>,
146146
) => {
147-
switch (item.id) {
148-
case ClusterActionMenuOptionIdEnum.DELETE:
149-
handleOpenDeleteModal()
150-
break
151-
default:
152-
break
147+
if (item.id === ClusterActionMenuOptionIdEnum.DELETE) {
148+
handleOpenDeleteModal()
153149
}
154150
}
155151

src/components/v2/appDetails/sourceInfo/EnvironmentSelector.component.tsx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -229,12 +229,8 @@ const EnvironmentSelectorComponent = ({
229229
const closeForceConfirmationModal = () => showForceDeleteDialog(false)
230230

231231
const handleActionMenuClick: ActionMenuProps['onClick'] = (item) => {
232-
switch (item.id) {
233-
case ClusterActionMenuOptionIdEnum.DELETE:
234-
showDeleteConfirmationPopup()
235-
break
236-
default:
237-
break
232+
if (item.id === ClusterActionMenuOptionIdEnum.DELETE) {
233+
handleDelete()
238234
}
239235
}
240236

0 commit comments

Comments
 (0)