Skip to content

Commit 522c3b5

Browse files
rename the env setter method names in the classes
1 parent b378e1a commit 522c3b5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/components/app/details/appDetails/AppDetails.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ export default function AppDetail({ filteredEnvIds }: { filteredEnvIds?: string
134134
selector = new ParamsAndEnvContext()
135135
}
136136

137-
const selectedEnvId = selector.handleCondition(params, environmentId, _envList, setEnvironmentId)
137+
const selectedEnvId = selector.resolveEnvironmentId(params, environmentId, _envList, setEnvironmentId)
138138

139139
// Set the URL and push to navigation stack
140140
if (selectedEnvId) {

src/components/app/details/appDetails/utils.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -738,19 +738,19 @@ export const validateMomentDate = (date: string, format: string): string => {
738738
}
739739

740740
class EnvironmentSelection {
741-
handleCondition(params, environmentId, _envList, setEnvironmentId) {
741+
resolveEnvironmentId(params, environmentId, _envList, setEnvironmentId) {
742742
throw new Error('This method should be overridden by concrete classes.')
743743
}
744744
}
745745

746746
export class NoParamsNoEnvContext extends EnvironmentSelection {
747-
handleCondition(params, environmentId, _envList, setEnvironmentId) {
747+
resolveEnvironmentId(params, environmentId, _envList, setEnvironmentId) {
748748
return _envList[0].environmentId
749749
}
750750
}
751751

752752
export class NoParamsWithEnvContext extends EnvironmentSelection {
753-
handleCondition(params, environmentId, _envList, setEnvironmentId) {
753+
resolveEnvironmentId(params, environmentId, _envList, setEnvironmentId) {
754754
if (environmentId && _envList.map((env) => env.environmentId).includes(environmentId)) {
755755
return environmentId
756756
}
@@ -759,7 +759,7 @@ export class NoParamsWithEnvContext extends EnvironmentSelection {
759759
}
760760

761761
export class ParamsNoEnvContext extends EnvironmentSelection {
762-
handleCondition(params, environmentId, _envList, setEnvironmentId) {
762+
resolveEnvironmentId(params, environmentId, _envList, setEnvironmentId) {
763763
if (params.envId && _envList.map((env) => env.environmentId).includes(+params.envId)) {
764764
return +params.envId
765765
}
@@ -768,7 +768,7 @@ export class ParamsNoEnvContext extends EnvironmentSelection {
768768
}
769769

770770
export class ParamsAndEnvContext extends EnvironmentSelection {
771-
handleCondition(params, environmentId, _envList, setEnvironmentId) {
771+
resolveEnvironmentId(params, environmentId, _envList, setEnvironmentId) {
772772
if (params.envId && _envList.map((env) => env.environmentId).includes(+params.envId)) {
773773
// If environmentId is present and different from params.envContext, set environmentId
774774
if (environmentId && +environmentId !== +params.envId) {

0 commit comments

Comments
 (0)