chore: clean base css

Author: AbhishekA1509

src/Pages/GlobalConfigurations/BuildInfra/ProfileForm.tsx

@@ -14,7 +14,6 @@ import './styles.scss'
 
 const ProfileForm: FunctionComponent = () => {
     const { breadcrumbs } = useBreadcrumb(BUILD_INFRA_BREADCRUMB)
-    // Sending isSuperAdmin since don't even want to send API Request for that case
     const {
         isLoading,
         profileResponse,
@@ -26,13 +25,10 @@ const ProfileForm: FunctionComponent = () => {
         loadingActionRequest,
         handleSubmit,
     } = useBuildInfraForm({ name: DEFAULT_PROFILE_NAME, editProfile: true })
-    // Would use this to disable the save button, if all keys in profileInputErrors are null, then there are no errors
-    // Might enhance this check later for other operations
+    // Would use this to disable the save button, if all keys in profileInputErrors are null or undefined, then there are no errors
+    // Empty string means isRequired but no need to show error below input field
     const formErrorCount = useMemo(
-        () =>
-            Object.keys(profileInputErrors).filter(
-                (item) => profileInputErrors[item] !== null && profileInputErrors[item] !== undefined,
-            ).length,
+        () => Object.keys(profileInputErrors).filter((item) => !profileInputErrors[item]).length,
         [profileInputErrors],
     )
 

src/components/globalConfigurations/GlobalConfiguration.tsx

@@ -486,15 +486,13 @@ function NavItem({ serverMode }) {
                             <div className="flexbox flex-justify">Lock Deployment config</div>
                         </NavLink>
                     )}
-                    {BuildInfra && (
-                        <NavLink
-                            to={URLS.GLOBAL_CONFIG_BUILD_INFRA}
-                            key={URLS.GLOBAL_CONFIG_BUILD_INFRA}
-                            activeClassName="active-route"
-                        >
-                            <div className="flexbox flex-justify">Build Infra</div>
-                        </NavLink>
-                    )}
+                    <NavLink
+                        to={URLS.GLOBAL_CONFIG_BUILD_INFRA}
+                        key={URLS.GLOBAL_CONFIG_BUILD_INFRA}
+                        activeClassName="active-route"
+                    >
+                        <div className="flexbox flex-justify">Build Infra</div>
+                    </NavLink>
                 </>
             )}
         </div>
@@ -612,7 +610,7 @@ function Body({ getHostURLConfig, checkList, serverMode, handleChecklistUpdate,
                 <Route key={URLS.GLOBAL_CONFIG_EXTERNAL_LINKS} path={URLS.GLOBAL_CONFIG_EXTERNAL_LINKS}>
                     <ExternalLinks />
                 </Route>,
-                ...(serverMode !== SERVER_MODE.EA_ONLY && BuildInfra
+                ...(serverMode !== SERVER_MODE.EA_ONLY
                     ? [
                           <Route key={URLS.GLOBAL_CONFIG_BUILD_INFRA} path={URLS.GLOBAL_CONFIG_BUILD_INFRA}>
                               <BuildInfra isSuperAdmin={isSuperAdmin} />

src/css/base.scss

@@ -2108,10 +2108,6 @@ button.anchor {
     border-bottom: 2px solid var(--N200);
 }
 
-.dc__border-bottom-b5-2 {
-    border-bottom: 2px solid var(--B500) !important;
-}
-
 .dc__border-left {
     border-left: solid 1px var(--N200);
 }
@@ -4126,7 +4122,7 @@ textarea::placeholder {
 
 .bulk-selection-widget {
     border: 1px solid var(--B500);
-    background: var(--light-blue);
+    background: var(--B50);
     box-shadow: 0px 4px 8px 0px rgba(0, 0, 0, 0.35);
     backdrop-filter: blur(5px);
 }
@@ -4135,9 +4131,9 @@ textarea::placeholder {
 // Tab behaviors
 .dc__tab-focus {
     outline: none;
-}
 
-.dc__tab-focus:focus-visible {
-    outline: 5px auto -webkit-focus-ring-color;
-    outline-offset: -2px;
+    &:focus-visible {
+        outline: 5px auto -webkit-focus-ring-color;
+        outline-offset: -2px;
+    }
 }

src/css/colorPalette.scss

@@ -10,7 +10,7 @@
     --B300: #72ace6;
     --B200: #abcff3;
     --B100: #e5f2ff;
-    --B50: #F0F7FF;
+    --B50: #f0f7ff;
     --N900: #000a14;
     --N800: #1d2730;
     --N700: #3b444c;
@@ -58,5 +58,4 @@
     --tippy-card-black-bg: #2d3452;
     --terminal-bg: #0b0f22;
     --inprogress-orange: #ff7e5b;
-    --light-blue: #f0f7ff;
 }