Merge pull request #2616 from devtron-labs/fix/stack-manager-icon

fix: render null icon

Author: arunjaindev

package.json

@@ -4,7 +4,7 @@
     "private": true,
     "homepage": "/dashboard",
     "dependencies": {
-        "@devtron-labs/devtron-fe-common-lib": "1.10.0-patch-4",
+        "@devtron-labs/devtron-fe-common-lib": "1.10.0-patch-5",
         "@esbuild-plugins/node-globals-polyfill": "0.2.3",
         "@rjsf/core": "^5.13.3",
         "@rjsf/utils": "^5.13.3",

src/components/common/navigation/NavigationRoutes.tsx

@@ -81,7 +81,7 @@ import { DEFAULT_GIT_OPS_FEATURE_FLAGS } from './constants'
 import { ParsedTabsData, ParsedTabsDataV1 } from '../DynamicTabs/types'
 import { SwitchThemeDialog } from '@Pages/Shared'
 import { SwitchThemeDialogProps } from '@Pages/Shared/SwitchThemeDialog/types'
-import { getShowStackManager } from 'src/utils'
+import { EnvironmentDataStateType } from './types'
 
 // Monaco Editor worker initialization
 self.MonacoEnvironment = {
@@ -152,16 +152,12 @@ export default function NavigationRoutes() {
     }
     const [environmentId, setEnvironmentId] = useState(null)
     const contextValue = useMemo(() => ({ environmentId, setEnvironmentId }), [environmentId])
-    const [environmentDataState, setEnvironmentDataState] = useState<
-        Pick<
-            MainContext,
-            'isAirgapped' | 'isManifestScanningEnabled' | 'canOnlyViewPermittedEnvOrgLevel' | 'featureGitOpsFlags'
-        >
-    >({
+    const [environmentDataState, setEnvironmentDataState] = useState<EnvironmentDataStateType>({
         isAirgapped: false,
         isManifestScanningEnabled: false,
         canOnlyViewPermittedEnvOrgLevel: false,
         featureGitOpsFlags: structuredClone(DEFAULT_GIT_OPS_FEATURE_FLAGS),
+        devtronManagedLicensingEnabled: false,
     })
     const [userPreferences, setUserPreferences] = useState<UserPreferencesType>(null)
     const [userPreferencesError, setUserPreferencesError] = useState<ServerErrors>(null)
@@ -173,7 +169,8 @@ export default function NavigationRoutes() {
         appTheme,
     } = useTheme()
 
-    const { isAirgapped, isManifestScanningEnabled, canOnlyViewPermittedEnvOrgLevel } = environmentDataState
+    const { isAirgapped, isManifestScanningEnabled, canOnlyViewPermittedEnvOrgLevel, devtronManagedLicensingEnabled } =
+        environmentDataState
 
     const handleCloseLicenseInfoDialog = () => {
         setLicenseInfoDialogType(null)
@@ -342,6 +339,7 @@ export default function NavigationRoutes() {
             isManifestScanningEnabled: false,
             canOnlyViewPermittedEnvOrgLevel: false,
             featureGitOpsFlags: structuredClone(DEFAULT_GIT_OPS_FEATURE_FLAGS),
+            devtronManagedLicensingEnabled: false,
         }
 
         if (!getEnvironmentData) {
@@ -361,6 +359,7 @@ export default function NavigationRoutes() {
                 isManifestScanningEnabled: result.isManifestScanningEnabled,
                 canOnlyViewPermittedEnvOrgLevel: result.canOnlyViewPermittedEnvOrgLevel,
                 featureGitOpsFlags: parsedFeatureGitOpsFlags,
+                devtronManagedLicensingEnabled: result.devtronManagedLicensingEnabled || false,
             }
         } catch {
             return fallbackResponse
@@ -408,6 +407,7 @@ export default function NavigationRoutes() {
                 isManifestScanningEnabled: environmentDataResponse.isManifestScanningEnabled,
                 canOnlyViewPermittedEnvOrgLevel: environmentDataResponse.canOnlyViewPermittedEnvOrgLevel,
                 featureGitOpsFlags: environmentDataResponse.featureGitOpsFlags,
+                devtronManagedLicensingEnabled: environmentDataResponse.devtronManagedLicensingEnabled,
             })
 
             setServerMode(serverModeResponse)
@@ -484,11 +484,13 @@ export default function NavigationRoutes() {
     }
     const _isOnboardingPage = isOnboardingPage()
 
-    const handleOpenLicenseInfoDialog = (initialDialogTab?: LicenseInfoDialogType.ABOUT | LicenseInfoDialogType.LICENSE) => {
+    const handleOpenLicenseInfoDialog = (
+        initialDialogTab?: LicenseInfoDialogType.ABOUT | LicenseInfoDialogType.LICENSE,
+    ) => {
         setLicenseInfoDialogType(initialDialogTab || LicenseInfoDialogType.ABOUT)
     }
 
-    const showStackManager = getShowStackManager(currentServerInfo.serverInfo?.installationType, !!licenseData)
+    const showStackManager = !devtronManagedLicensingEnabled
 
     return (
         <MainContextProvider

src/components/common/navigation/types.ts

@@ -15,7 +15,12 @@
  */
 
 import { URLS } from '@Config/routes'
-import { customEnv, IconsProps, URLS as CommonURLS } from '@devtron-labs/devtron-fe-common-lib'
+import {
+    customEnv,
+    IconsProps,
+    URLS as CommonURLS,
+    EnvironmentDataValuesDTO,
+} from '@devtron-labs/devtron-fe-common-lib'
 
 export interface NavigationListItemType {
     title: string
@@ -32,3 +37,7 @@ export interface NavigationListItemType {
     moduleName?: string
     moduleNameTrivy?: string
 }
+
+export interface EnvironmentDataStateType extends Omit<EnvironmentDataValuesDTO, 'isAirGapEnvironment'> {
+    isAirgapped: boolean
+}

src/components/v2/devtronStackManager/DevtronStackManager.component.tsx

@@ -81,7 +81,6 @@ import clair from '../../../assets/icons/ic-trivy-to-clair.svg'
 import warn from '../../../assets/icons/ic-error-medium.svg'
 import { SuccessModalComponent } from './SuccessModalComponent'
 import { EMPTY_STATE_STATUS } from '../../../config/constantMessaging'
-import { getShowStackManager } from 'src/utils'
 
 const getInstallationStatusLabel = (
     installationStatus: ModuleStatus,
@@ -254,8 +253,6 @@ export const NavItem = ({
     showInitializing,
     showVersionInfo,
 }: StackManagerNavItemType): JSX.Element => {
-    const { currentServerInfo, licenseData } = useMainContext()
-
     const getNavLink = (route: StackManagerNavLinkType): JSX.Element => {
         return (
             <NavLink
@@ -304,18 +301,12 @@ export const NavItem = ({
         )
     }
 
-    const showAboutDevtronTab = getShowStackManager(currentServerInfo?.serverInfo?.installationType, !!licenseData)
-
     return (
         <div className="flex column left">
             <div className="section-heading cn-6 fs-12 fw-6 pl-8 mb-8 dc__uppercase">Integrations</div>
             {ModulesSection.map((route) => getNavLink(route))}
-            {showAboutDevtronTab && (
-                <>
-                    <hr className="mt-8 mb-8 w-100 checklist__divider" />
-                    {getNavLink(AboutSection)}
-                </>
-            )}
+            <hr className="mt-8 mb-8 w-100 checklist__divider" />
+            {getNavLink(AboutSection)}
         </div>
     )
 }
@@ -917,7 +908,7 @@ export const InstallationWrapper = ({
                                             }}
                                             showTooltip={isInstallButtonDisabled}
                                             text={text}
-                                            startIcon={<Icon />}
+                                            startIcon={Icon ? <Icon /> : null}
                                             fullWidth
                                         />
                                     )}

src/utils.tsx

@@ -5,7 +5,6 @@ import {
     DATE_TIME_FORMATS,
     getCentralAPIHealthObjectFromLocalStorage,
 } from '@devtron-labs/devtron-fe-common-lib'
-import { InstallationType } from '@Components/v2/devtronStackManager/DevtronStackManager.type'
 import { Routes } from '@Config/constants'
 
 const setCentralAPIHealthInLocalStorage = (health: boolean, existingHealthObj: CentralAPILocalConfig) => {
@@ -48,6 +47,3 @@ export const getCentralAPIHealth = async (): Promise<void> => {
         setCentralAPIHealthInLocalStorage(false, existingHealthObj)
     }
 }
-
-export const getShowStackManager = (installationType: InstallationType, showLicenseData: boolean) =>
-    installationType === InstallationType.ENTERPRISE ? showLicenseData : true

yarn.lock

@@ -1126,10 +1126,10 @@
   dependencies:
     "@jridgewell/trace-mapping" "0.3.9"
 
-"@devtron-labs/[email protected]4":
-  version "1.10.0-patch-4"
-  resolved "https://registry.yarnpkg.com/@devtron-labs/devtron-fe-common-lib/-/devtron-fe-common-lib-1.10.0-patch-4.tgz#347759b5e0477527e44cf066ef8a9bc2689ca39b"
-  integrity sha512-bCO7G/IyXKFi4CIJmUe6kmUKjzAM/AJlOWoItf6pJV3tiPGWURFpD9nYMSWTsUJYFu1op4plFdle42f9zIi0kA==
+"@devtron-labs/[email protected]5":
+  version "1.10.0-patch-5"
+  resolved "https://registry.yarnpkg.com/@devtron-labs/devtron-fe-common-lib/-/devtron-fe-common-lib-1.10.0-patch-5.tgz#26a13c55a38357968b6a21db1c5d940ca271f97c"
+  integrity sha512-zZJzMxn7VpuMl/HLZ5ZEpG4BTo1Mi666saZLVRiaaFtclTQDnEDzm6WgWSg/7dvOVM8UPEWoJjT8mBb+q9SZhA==
   dependencies:
     "@codemirror/lang-json" "6.0.1"
     "@codemirror/lang-yaml" "6.1.2"