feat: remove checks for hiding diff from tile in case of last deployed config

Author: arunjaindev

src/components/app/details/triggerView/PipelineConfigDiff/PipelineConfigDiffStatusTile.tsx

@@ -14,12 +14,7 @@
  * limitations under the License.
  */
 
-import {
-    DeploymentConfigDiffRadioSelect,
-    DeploymentWithConfigType,
-    Progressing,
-    Tooltip,
-} from '@devtron-labs/devtron-fe-common-lib'
+import { DeploymentConfigDiffRadioSelect, Icon, Tooltip } from '@devtron-labs/devtron-fe-common-lib'
 
 import { ReactComponent as ICWarning } from '@Icons/ic-warning.svg'
 
@@ -33,13 +28,9 @@ export const PipelineConfigDiffStatusTile = ({
     noLastDeploymentConfig,
     onClick,
     canReviewConfig,
-    urlFilters,
     renderConfigNotAvailableTooltip,
     radioSelectConfig,
 }: PipelineConfigDiffStatusTileProps) => {
-    const { deploy } = urlFilters
-    const lastDeployedOptionSelected = deploy === DeploymentWithConfigType.LATEST_TRIGGER_CONFIG
-    const lastSavedConfigOptionSelected = deploy === DeploymentWithConfigType.LAST_SAVED_CONFIG
     const _canReviewConfig = canReviewConfig && !noLastDeploymentConfig
 
     // RENDERERS
@@ -68,20 +59,12 @@ export const PipelineConfigDiffStatusTile = ({
     const renderConfigViewState = () => (_canReviewConfig ? renderDiffState() : renderConfigNotAvailableState())
 
     const renderReviewState = () =>
-        _canReviewConfig || lastDeployedOptionSelected || noLastDeploymentConfig ? (
-            <span className="cb-5 mt-3 mb-3">REVIEW</span>
-        ) : null
+        _canReviewConfig || noLastDeploymentConfig ? <span className="cb-5 mt-3 mb-3">REVIEW</span> : null
 
     const renderLoadingState = () => (
         <span className="dc__border-radius-24 flex dc__gap-4 py-3 px-12 fs-12 fw-6 lh-20 cn-0 bcb-5">
             <span>Checking diff</span>
-            <Progressing
-                size={16}
-                fillColor="white"
-                styles={{
-                    width: 'auto',
-                }}
-            />
+            <Icon name="ic-circle-loader" color="N0" />
         </span>
     )
 
@@ -92,7 +75,7 @@ export const PipelineConfigDiffStatusTile = ({
                 <DeploymentConfigDiffRadioSelect radioSelectConfig={radioSelectConfig} position="top" />
             </div>
             <Tooltip
-                alwaysShowTippyOnHover={!isLoading && !lastDeployedOptionSelected && !noLastDeploymentConfig}
+                alwaysShowTippyOnHover={!isLoading && !noLastDeploymentConfig}
                 content={
                     noLastDeploymentConfig
                         ? renderConfigNotAvailableTooltip()
@@ -107,11 +90,7 @@ export const PipelineConfigDiffStatusTile = ({
                         disabled={isLoading || !canReviewConfig}
                         onClick={onClick}
                     >
-                        {!lastDeployedOptionSelected &&
-                            !noLastDeploymentConfig &&
-                            (isLoading && !lastSavedConfigOptionSelected
-                                ? renderLoadingState()
-                                : renderConfigViewState())}
+                        {!noLastDeploymentConfig && (isLoading ? renderLoadingState() : renderConfigViewState())}
                         {renderReviewState()}
                     </button>
                 </div>

src/components/app/details/triggerView/PipelineConfigDiff/types.ts

@@ -48,7 +48,7 @@ export type PipelineConfigDiffProps = Pick<
 }
 
 export interface PipelineConfigDiffStatusTileProps
-    extends Pick<PipelineConfigDiffProps, 'isLoading' | 'radioSelectConfig' | 'urlFilters'> {
+    extends Pick<PipelineConfigDiffProps, 'isLoading' | 'radioSelectConfig'> {
     hasDiff?: boolean
     noLastDeploymentConfig?: boolean
     onClick?: (e: React.MouseEvent<HTMLButtonElement>) => void

src/components/app/details/triggerView/cdMaterial.tsx

@@ -1795,7 +1795,6 @@ const CDMaterial = ({
                         onClick={() => onClickSetInitialParams('review-config')}
                         noLastDeploymentConfig={noLastDeploymentConfig}
                         canReviewConfig={canReviewConfig()}
-                        urlFilters={urlFilters}
                         renderConfigNotAvailableTooltip={renderTippyContent}
                     />
                 ) : (