fix: typing issues

Author: eshankvaish

src/components/app/details/appDetails/SourceInfo.tsx

@@ -14,9 +14,8 @@
  * limitations under the License.
  */
 
-// @ts-nocheck - @TODO: Remove this by fixing the type issues
-import React, { useEffect, useMemo, useState } from 'react'
-import { useParams } from 'react-router-dom'
+import { useEffect, useMemo, useState } from 'react'
+import { Link, useParams } from 'react-router-dom'
 import Tippy from '@tippyjs/react'
 import moment from 'moment'
 import {
@@ -48,7 +47,6 @@ import { ReactComponent as RotateIcon } from '../../../../assets/icons/ic-arrows
 import { ReactComponent as LinkIcon } from '../../../../assets/icons/ic-link.svg'
 import { ReactComponent as Trash } from '../../../../assets/icons/ic-delete-dots.svg'
 import { ReactComponent as ScaleDown } from '../../../../assets/icons/ic-scale-down.svg'
-import { ConfigApplyStatusCard } from './ConfigApplyStatusCard'
 import HelmAppConfigApplyStatusCard from '@Components/v2/appDetails/sourceInfo/environmentStatus/HelmAppConfigApplyStatusCard'
 
 const AppDetailsDownloadCard = importComponentFromFELibrary('AppDetailsDownloadCard')
@@ -192,7 +190,8 @@ export const SourceInfo = ({
                         }`}
                     >
                         <div className={`flex ${!appDetails.isVirtualEnvironment ? 'ml-16' : ''}`}>
-                            <DeploymentTypeIcon deploymentAppType={appDetails?.deploymentAppType} />
+                            {/* TODO: verify what appType needs to be passed */}
+                            <DeploymentTypeIcon deploymentAppType={appDetails?.deploymentAppType} appType={null} />
                         </div>
                     </Tooltip>
                 )}
@@ -210,7 +209,9 @@ export const SourceInfo = ({
                             <div className="fw-4 lh-18 flexbox-col dc__ga-2">
                                 <h6 className="fs-12 fw-6 cn-0 m-0">Last snapshot received</h6>
                                 <p className="m-0 fs-12 cn-50">
-                                    {moment(relativeSnapshotTime).format(DATE_TIME_FORMATS.TWELVE_HOURS_FORMAT)}
+                                    {moment(appDetails.resourceTree.lastSnapshotTime).format(
+                                        DATE_TIME_FORMATS.TWELVE_HOURS_FORMAT,
+                                    )}
                                 </p>
                             </div>
                         }
@@ -220,9 +221,7 @@ export const SourceInfo = ({
                             <div className="dc__divider h-20 mr-8 ml-8" />
                             <div className="flex left dc__gap-6 px-8 py-4">
                                 <ICCamera className="scn-9 dc__no-shrink icon-dim-16" />
-                                <p className="m-0 fs-13 fw-4 lh-20 cn-9 dc__truncate">
-                                    {deploymentStatusDetailsBreakdownData.statusLastFetchedAt}
-                                </p>
+                                <p className="m-0 fs-13 fw-4 lh-20 cn-9 dc__truncate">{relativeSnapshotTime}</p>
                             </div>
                         </div>
                     </Tooltip>
@@ -264,7 +263,7 @@ export const SourceInfo = ({
                                         <button
                                             data-testid="app-details-rotate-pods-modal-button"
                                             className="cta cta-with-img small cancel fs-12 fw-6 mr-6"
-                                            onClick={setRotateModal}
+                                            onClick={() => setRotateModal(true)}
                                             disabled={isApprovalConfigured}
                                         >
                                             <RotateIcon className="icon-dim-16 mr-6 icon-color-n7 scn-4" />
@@ -319,13 +318,15 @@ export const SourceInfo = ({
                   environment && (
                       <div className="flex left w-100">
                           {status && (
-                              <AppStatusCard
-                                  appDetails={appDetails}
-                                  status={status}
-                                  cardLoading={cardLoading}
-                                  setDetailed={setDetailed}
-                                  message={message}
-                              />
+                            <AppStatusCard
+                                // TODO: Fix and remove
+                                // @ts-ignore
+                                appDetails={appDetails}
+                                status={status}
+                                cardLoading={cardLoading}
+                                setDetailed={setDetailed}
+                                message={message}
+                            />
                           )}
                           {!helmMigratedAppNotTriggered && (
                               <>

src/components/app/details/appDetails/appDetails.type.ts

@@ -232,7 +232,7 @@ export interface SecurityVulnerabilityCardType {
 }
 
 export interface DeployedCommitCardType {
-    showCommitInfoDrawer: () => void
+    showCommitInfoDrawer: (e) => void
     cardLoading?: boolean
     envId: number | string
     ciArtifactId: number

src/components/app/types.ts

@@ -25,6 +25,7 @@ import {
     RuntimeParamsListItemType,
     RuntimeParamsTriggerPayloadType,
     ReleaseMode,
+    HelmReleaseStatus,
 } from '@devtron-labs/devtron-fe-common-lib'
 import { RouteComponentProps } from 'react-router'
 import { AppEnvironment } from '../../services/service.types'
@@ -90,9 +91,14 @@ export interface CDModalProps {
     parentEnvironmentName: string
     ciPipelineId?: number
     isRedirectedFromAppDetails?: boolean
+    deploymentUserActionState?: ACTION_STATE
 }
 
 export interface AppDetails extends CDModalProps {
+    appStoreChartId: number
+    appStoreChartName: string
+    appStoreAppVersion: string
+    appStoreAppName: string
     appId: number
     deploymentAppType?: DeploymentAppTypes
     externalCi?: boolean
@@ -188,6 +194,7 @@ interface ResourceTree {
     podMetadata: PodMetadatum[]
     conditions?: any
     lastSnapshotTime?: string
+    releaseStatus?: HelmReleaseStatus
 }
 
 interface Node {