Skip to content

Commit 69e98ec

Browse files
committed
feat: show startegy in external linked apps if not custom chart
1 parent 2e25f83 commit 69e98ec

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

src/components/cdPipeline/BuildCD.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export default function BuildCD({
8181
isGitOpsRepoNotConfigured,
8282
noGitOpsModuleInstalledAndConfigured,
8383
releaseMode,
84+
isCustomChart,
8485
getMandatoryPluginData,
8586
migrateToDevtronFormState,
8687
setMigrateToDevtronFormState,
@@ -672,7 +673,7 @@ export default function BuildCD({
672673
}
673674

674675
const renderAdvancedDeploymentStrategy = () => {
675-
if (noStrategyAvailable.current || releaseMode === ReleaseMode.MIGRATE_EXTERNAL_APPS) {
676+
if (noStrategyAvailable.current || (releaseMode === ReleaseMode.MIGRATE_EXTERNAL_APPS && isCustomChart)) {
676677
return null
677678
}
678679

src/components/cdPipeline/CDPipeline.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ export default function CDPipeline({
179179
deploymentAppType: window._env_.HIDE_GITOPS_OR_HELM_OPTION ? '' : DeploymentAppTypes.HELM,
180180
deploymentAppName: '',
181181
releaseMode: ReleaseMode.NEW_DEPLOYMENT,
182+
isCustomChart: false,
182183
triggerType: TriggerType.Auto,
183184
strategies: [],
184185
savedStrategies: [],
@@ -601,6 +602,7 @@ export default function CDPipeline({
601602
form.name = pipelineConfigFromRes.name
602603
form.deploymentAppName = pipelineConfigFromRes.deploymentAppName
603604
form.releaseMode = pipelineConfigFromRes.releaseMode
605+
form.isCustomChart = pipelineConfigFromRes.isCustomChart
604606
form.environmentName = pipelineConfigFromRes.environmentName || ''
605607
form.namespace = env.namespace
606608
form.repoName = pipelineConfigFromRes.repoName
@@ -1368,6 +1370,7 @@ export default function CDPipeline({
13681370
isGitOpsRepoNotConfigured={isGitOpsRepoNotConfigured}
13691371
noGitOpsModuleInstalledAndConfigured={noGitOpsModuleInstalledAndConfigured}
13701372
releaseMode={formData.releaseMode}
1373+
isCustomChart={formData.isCustomChart}
13711374
getMandatoryPluginData={getMandatoryPluginData}
13721375
migrateToDevtronFormState={migrateToDevtronFormState}
13731376
setMigrateToDevtronFormState={setMigrateToDevtronFormState}

src/components/cdPipeline/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ export interface BuildCDProps
9191
isWebhookCD: boolean
9292
dockerRegistries: any[]
9393
releaseMode: ReleaseMode
94+
isCustomChart: boolean
9495
getMandatoryPluginData: (
9596
form: PipelineFormType,
9697
requiredPluginIds?: PluginDetailPayloadType['pluginIds'],

0 commit comments

Comments
 (0)