Skip to content

Commit 6aa1c46

Browse files
committed
Merge branch 'develop' into chore/main-sync
2 parents d5c390c + 2b337b7 commit 6aa1c46

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+392
-203
lines changed

.env

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,5 @@ FEATURE_DEFAULT_LANDING_RB_ENABLE=false
6262
FEATURE_ACTION_AUDIOS_ENABLE=true
6363
FEATURE_APPLICATION_TEMPLATES_ENABLE=true
6464
FEATURE_CODE_MIRROR_ENABLE=false
65-
FEATURE_EXPERIMENTAL_THEMING_ENABLE=true
6665
FEATURE_DEFAULT_AUTHENTICATED_VIEW_ENABLE=false
6766
GATEKEEPER_URL=devtron.ai

.storybook/preview.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
useTheme,
1515
} from '@devtron-labs/devtron-fe-common-lib'
1616
import { SwitchThemeDialog } from '../src/Pages/Shared'
17+
import './storybook.css'
1718

1819
const SwitchThemeDialogWrapper = () => {
1920
const { showThemeSwitcherDialog, themePreference, handleThemeSwitcherDialogVisibilityChange } = useTheme()
@@ -22,7 +23,7 @@ const SwitchThemeDialogWrapper = () => {
2223
}
2324

2425
return (
25-
showThemeSwitcherDialog ? <SwitchThemeDialog initialThemePreference={themePreference} handleClose={handleClose} disableAPICalls /> : null
26+
showThemeSwitcherDialog ? <SwitchThemeDialog initialThemePreference={themePreference} handleClose={handleClose} disableAPICalls handleUpdateUserThemePreference={noop} /> : null
2627
)
2728
}
2829

@@ -37,9 +38,7 @@ const preview: Preview = {
3738
},
3839
decorators: (Story) => {
3940
if (!window._env_) {
40-
window._env_ = {
41-
FEATURE_EXPERIMENTAL_THEMING_ENABLE: true,
42-
} as customEnv
41+
window._env_ = {} as customEnv
4342
}
4443

4544
return (

.storybook/storybook.css

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
body {
2+
background: var(--bg-primary);
3+
}

config.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,5 @@
4545
| TRIGGER_API_TIMEOUT | 60000 | Default timeout for all API requests for Trigger calls (Deploy artifacts, charts) in DASHBOARD |
4646
| FEATURE_HIDE_USER_DIRECT_PERMISSIONS_FOR_NON_SUPER_ADMINS | "true" | Would hide the user direct permissions for non-super admin users in User Permissions |
4747
| FEATURE_ACTION_AUDIOS_ENABLE | true | Would enable audios in dashboard |
48-
| FEATURE_EXPERIMENTAL_THEMING_ENABLE | true | Would enable theming in dashboard |
4948

5049
# DASHBOARD CONFIG SECRET

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"homepage": "/dashboard",
66
"dependencies": {
7-
"@devtron-labs/devtron-fe-common-lib": "1.10.0-patch-3",
7+
"@devtron-labs/devtron-fe-common-lib": "1.10.6",
88
"@esbuild-plugins/node-globals-polyfill": "0.2.3",
99
"@rjsf/core": "^5.13.3",
1010
"@rjsf/utils": "^5.13.3",

src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentConfigCompare/DeploymentConfigCompare.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ export const DeploymentConfigCompare = ({
459459
classNamePrefix: 'compare-with-environment-selector',
460460
inputId: 'compare-with-environment-selector',
461461
name: 'compare-with-environment-selector',
462-
variant: SelectPickerVariantType.BORDER_LESS,
462+
variant: SelectPickerVariantType.COMPACT,
463463
value: getSelectPickerOptionByValue(compareEnvironmentSelectorOptions, chartRefId || compareWith, {
464464
label: BASE_CONFIGURATIONS.name,
465465
value: '',
@@ -497,7 +497,7 @@ export const DeploymentConfigCompare = ({
497497
classNamePrefix: 'environment-config-type-selector',
498498
inputId: `environment-config-type-selector-${isCompare ? 'compare' : 'current'}`,
499499
name: `environment-config-type-selector-${isCompare ? 'compare' : 'current'}`,
500-
variant: SelectPickerVariantType.BORDER_LESS,
500+
variant: SelectPickerVariantType.COMPACT,
501501
isSearchable: false,
502502
disableDescriptionEllipsis: true,
503503
value: getSelectPickerOptionByValue(

src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DTChartSelector.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ const DTChartSelector = ({
253253
value={selectedOption}
254254
onChange={onSelectChartVersion}
255255
isSearchable={false}
256-
variant={SelectPickerVariantType.BORDER_LESS}
256+
variant={SelectPickerVariantType.COMPACT}
257257
size={ComponentSizeType.small}
258258
placeholder="Select version"
259259
isDisabled={migratedFrom === PipelineMigratedFromType.ARGO_APPLICATION}

src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentTemplate/DeploymentTemplateOptionsHeader.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ import {
1919
InvalidYAMLTippyWrapper,
2020
SegmentedControl,
2121
CONFIGURATION_TYPE_OPTIONS,
22-
SegmentedControlVariant,
22+
SegmentedControlProps,
23+
ComponentSizeType,
2324
} from '@devtron-labs/devtron-fe-common-lib'
2425
import DTChartSelector from './DTChartSelector'
2526
import { DeploymentTemplateOptionsHeaderProps } from './types'
@@ -46,8 +47,8 @@ const DeploymentTemplateOptionsHeader = ({
4647
return null
4748
}
4849

49-
const handleToggleEditMode = (e: React.ChangeEvent<HTMLInputElement>) => {
50-
if (e.target.value === ConfigurationType.YAML) {
50+
const handleToggleEditMode: SegmentedControlProps['onChange'] = (selectedSegment) => {
51+
if (selectedSegment.value === ConfigurationType.YAML) {
5152
handleChangeToYAMLMode()
5253
return
5354
}
@@ -65,13 +66,12 @@ const DeploymentTemplateOptionsHeader = ({
6566
>
6667
<div>
6768
<SegmentedControl
68-
tabs={CONFIGURATION_TYPE_OPTIONS}
69-
initialTab={editMode}
69+
segments={CONFIGURATION_TYPE_OPTIONS}
70+
value={editMode}
7071
onChange={handleToggleEditMode}
7172
disabled={!!parsingError}
72-
rootClassName="h-20"
73+
size={ComponentSizeType.xs}
7374
name="dt-yaml-gui-segmented-control"
74-
variant={SegmentedControlVariant.GRAY_ON_WHITE}
7575
/>
7676
</div>
7777
</InvalidYAMLTippyWrapper>

src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/SelectMergeStrategy.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ const SelectMergeStrategy = ({
7878
value={selectedOption}
7979
options={options}
8080
isDisabled={isDisabled}
81-
variant={SelectPickerVariantType.BORDER_LESS}
81+
variant={SelectPickerVariantType.COMPACT}
8282
isSearchable={false}
8383
size={ComponentSizeType.small}
8484
isOptionDisabled={getIsOptionDisabled}

src/Pages/Applications/DevtronApps/Details/AppConfigurations/Navigation/EnvConfigurationsNav.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@ export const EnvConfigurationsNav = ({
404404
<SelectPicker<number, false>
405405
inputId="env-config-selector"
406406
classNamePrefix="env-config-selector"
407-
variant={SelectPickerVariantType.BORDER_LESS}
407+
variant={SelectPickerVariantType.COMPACT}
408408
isClearable={false}
409409
value={getSelectPickerOptionByValue(envOptions, parsedResourceId, baseEnvOption[0])}
410410
options={envOptions}

0 commit comments

Comments
 (0)