Skip to content

Commit 6d3e176

Browse files
committed
fix: variable naming clean up
1 parent 953267a commit 6d3e176

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

src/Pages/GlobalConfigurations/Authorization/PermissionGroups/List/PermissionGroupList.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ const PermissionGroupList = () => {
8585
error={error}
8686
getPermissionGroupDataForExport={getPermissionGroupDataForExport}
8787
showLoadingState={showLoadingState}
88-
totalCount={result?.totalCount}
88+
totalCount={result?.totalCount ?? 0}
8989
permissionGroups={result?.permissionGroups ?? []}
9090
refetchPermissionGroupList={reload}
9191
urlFilters={urlFilters}

src/Pages/GlobalConfigurations/Authorization/PermissionGroups/List/PermissionGroupRow.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ const PermissionGroupRow = ({
2424
refetchPermissionGroupList,
2525
isChecked = false,
2626
toggleChecked,
27-
showCheckbox: _showCheckbox,
27+
showCheckbox,
2828
}: PermissionGroupRowProps) => {
2929
const { path } = useRouteMatch()
3030
const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false)
3131
const [isModalLoading, setIsModalLoading] = useState(false)
3232
const { isBulkSelectionApplied, handleBulkSelection } = useAuthorizationBulkSelection()
3333

34-
const showCheckbox = _showCheckbox || isChecked
34+
const _showCheckbox = showCheckbox || isChecked
3535

3636
const toggleDeleteModal = () => {
3737
setIsDeleteModalOpen(!isDeleteModalOpen)
@@ -70,7 +70,7 @@ const PermissionGroupRow = ({
7070
}`}
7171
>
7272
<div className="flex dc__content-start">
73-
{!showCheckbox && (
73+
{!_showCheckbox && (
7474
<span
7575
className="icon-dim-20 mw-20 flex dc__border-radius-50-per dc__uppercase cn-0 fw-4 dc__visible-hover--hide-child"
7676
style={{
@@ -83,7 +83,7 @@ const PermissionGroupRow = ({
8383
<Checkbox
8484
isChecked={isChecked}
8585
onChange={handleChecked}
86-
rootClassName={`mb-0 ${showCheckbox ? '' : 'dc__visible-hover--child'}`}
86+
rootClassName={`mb-0 ${_showCheckbox ? '' : 'dc__visible-hover--child'}`}
8787
value={CHECKBOX_VALUE.CHECKED}
8888
/>
8989
</div>

src/Pages/GlobalConfigurations/Authorization/UserPermissions/List/UserPermissionList.component.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,24 +29,24 @@ const UserPermissionList = () => {
2929
type: null,
3030
})
3131

32-
const { status, ..._urlFilters } = useUrlFilters<UserListSortableKeys, UserListFilter>({
32+
const { status, ...urlFilters } = useUrlFilters<UserListSortableKeys, UserListFilter>({
3333
initialSortKey: UserListSortableKeys.email,
3434
parseSearchParams,
3535
})
3636

3737
const updateStatusFilter = (_status: UserStatus[]) => {
38-
_urlFilters.updateSearchParams({
38+
urlFilters.updateSearchParams({
3939
status: _status,
4040
})
4141
}
4242

43-
const urlFilters = {
44-
..._urlFilters,
43+
const _urlFilters = {
44+
...urlFilters,
4545
status,
4646
updateStatusFilter,
4747
}
4848

49-
const { pageSize, offset, searchKey, sortBy, sortOrder } = urlFilters
49+
const { pageSize, offset, searchKey, sortBy, sortOrder } = _urlFilters
5050
const filterConfig = useMemo(
5151
() => ({
5252
size: pageSize,
@@ -116,10 +116,10 @@ const UserPermissionList = () => {
116116
error={error}
117117
getUserDataForExport={getUserDataForExport}
118118
showLoadingState={showLoadingState}
119-
totalCount={result?.totalCount}
119+
totalCount={result?.totalCount ?? 0}
120120
users={result?.users ?? []}
121121
refetchUserPermissionList={reload}
122-
urlFilters={urlFilters}
122+
urlFilters={_urlFilters}
123123
bulkSelectionModalConfig={bulkSelectionModalConfig}
124124
setBulkSelectionModalConfig={setBulkSelectionModalConfig}
125125
/>

src/Pages/GlobalConfigurations/Authorization/UserPermissions/List/UserPermissionRow.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ const UserPermissionRow = ({
3939
refetchUserPermissionList,
4040
isChecked = false,
4141
toggleChecked,
42-
showCheckbox: _showCheckbox,
42+
showCheckbox,
4343
}: UserPermissionRowProps) => {
4444
const { path } = useRouteMatch()
4545
const isAdminOrSystemUser = getIsAdminOrSystemUser(emailId)
4646
const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false)
4747
const [isModalLoading, setIsModalLoading] = useState(false)
4848
const { handleBulkSelection, isBulkSelectionApplied } = useAuthorizationBulkSelection()
4949

50-
const showCheckbox = _showCheckbox || isChecked
50+
const _showCheckbox = showCheckbox || isChecked
5151

5252
const toggleDeleteModal = () => {
5353
setIsDeleteModalOpen(!isDeleteModalOpen)
@@ -89,7 +89,7 @@ const UserPermissionRow = ({
8989
>
9090
{/* Note (v2): no checkbox for admin/system */}
9191
<div className="flex dc__content-start">
92-
{(!showCheckbox || isAdminOrSystemUser) && (
92+
{(!_showCheckbox || isAdminOrSystemUser) && (
9393
<span
9494
className={`icon-dim-20 mw-20 flex dc__border-radius-50-per dc__uppercase cn-0 fw-4 ${
9595
isAdminOrSystemUser ? '' : 'dc__visible-hover--hide-child'
@@ -105,7 +105,7 @@ const UserPermissionRow = ({
105105
<Checkbox
106106
isChecked={isChecked}
107107
onChange={handleChecked}
108-
rootClassName={`mb-0 ${showCheckbox ? '' : 'dc__visible-hover--child'}`}
108+
rootClassName={`mb-0 ${_showCheckbox ? '' : 'dc__visible-hover--child'}`}
109109
value={CHECKBOX_VALUE.CHECKED}
110110
/>
111111
)}

0 commit comments

Comments
 (0)