Skip to content

Commit 7440613

Browse files
committed
chore: add position in variable data popup
1 parent b5399d4 commit 7440613

File tree

4 files changed

+6
-1
lines changed

4 files changed

+6
-1
lines changed

src/components/CIPipelineN/VariableDataTable/ValueConfigOverlay.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,6 +316,7 @@ export const ValueConfigOverlay = ({ row, handleRowUpdateAction }: ConfigOverlay
316316
(row.data.format.value === VariableTypeFormat.FILE && (hasFileMountError || !!fileSize.error)) ||
317317
(row.data.format.value === VariableTypeFormat.NUMBER && hasChoicesError)
318318
}
319+
position="bottom"
319320
>
320321
<>
321322
{renderContent()}

src/components/CIPipelineN/VariableDataTable/VariableConfigOverlay.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export const VariableConfigOverlay = ({ row, handleRowUpdateAction }: ConfigOver
5959
}
6060

6161
return (
62-
<VariableDataTablePopupMenu showHeaderIcon heading="Variable configuration">
62+
<VariableDataTablePopupMenu showHeaderIcon heading="Variable configuration" position="right">
6363
<>
6464
<div className="p-12 flexbox-col dc__gap-12">
6565
<CustomInput

src/components/CIPipelineN/VariableDataTable/VariableDataTablePopupMenu.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ export const VariableDataTablePopupMenu = ({
3636
heading,
3737
children,
3838
onClose,
39+
position,
3940
disableClose = false,
4041
}: VariableDataTablePopupMenuProps) => {
4142
const { open, overlayProps, popoverProps, triggerProps, scrollableRef, closePopover } = usePopover({
@@ -47,6 +48,7 @@ export const VariableDataTablePopupMenu = ({
4748
}
4849
},
4950
disableClose,
51+
position,
5052
})
5153

5254
const triggerElement = (

src/components/CIPipelineN/VariableDataTable/types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import {
2121
RefVariableStageType,
2222
RefVariableType,
2323
SelectPickerOptionType,
24+
UsePopoverProps,
2425
VariableType,
2526
VariableTypeFormat,
2627
} from '@devtron-labs/devtron-fe-common-lib'
@@ -144,6 +145,7 @@ export interface VariableDataTablePopupMenuProps {
144145
disableClose?: boolean
145146
onClose?: () => void
146147
children: JSX.Element
148+
position: UsePopoverProps['position']
147149
}
148150

149151
export interface ConfigOverlayProps {

0 commit comments

Comments
 (0)