Skip to content

Commit 74f9621

Browse files
committed
feat: update ga events for app env group filter
1 parent 0e12961 commit 74f9621

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/components/ApplicationGroup/AppGroupAppFilter.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,10 @@ export default function AppGroupAppFilter() {
5353
setSelectedFilterTab(_filterTab)
5454
}
5555

56-
const handleFilterGAEvent = (isItemClick?: boolean) => {
56+
const handleFilterGAEvent = (filterType?: string) => {
5757
ReactGA.event({
5858
category: 'Group filter',
59-
action: `${filterParentType} filter ${isItemClick ? 'item' : ''} clicked`,
59+
action: `${filterParentType === FilterParentType.app ? 'DA_ENV' : 'AG_APP'}_FILTER${filterType ? `_${filterType}` : ''}_CLICKED`,
6060
})
6161
}
6262

@@ -118,7 +118,7 @@ export default function AppGroupAppFilter() {
118118
})
119119
}
120120
}
121-
handleFilterGAEvent(true)
121+
handleFilterGAEvent(selectedFilterTab === AppFilterTabs.APP_FILTER ? 'ITEM' : 'SAVED_ITEM')
122122
}
123123

124124
const getPlaceHolder = (): string => {

src/components/ResourceBrowser/ResourceList/BaseResourceList.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ const BaseResourceListContent = ({
192192

193193
const gvkString = useMemo(
194194
() =>
195-
Object.values(selectedResource?.gvk || {})
195+
Object.values(selectedResource?.gvk ?? {})
196196
.filter((value) => !!value)
197197
.join('/'),
198198
[selectedResource],

src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetailTabs/EventsTable.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export const EventsTable = ({
8181
const isNormalEventType = type === 'Normal'
8282
return (
8383
<div
84+
key={`${reason}-${message}`}
8485
className={`px-16 py-12 fs-14 fw-4 lh-1-5 dc__grid dc__gap-16 event-row ${ExplainWithAIButton ? 'ai-widget' : ''} ${index % 2 === 0 && 'alternate-row'}`}
8586
>
8687
<Icon

0 commit comments

Comments
 (0)