Skip to content

Commit 7c8a076

Browse files
committed
fixed code smells
1 parent 702f56a commit 7c8a076

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

src/components/ApplicationGroup/AppGroup.service.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import {
2222
EnvAppType,
2323
EnvDeploymentStatusType,
2424
EnvGroupListResponse,
25-
EnvGroupListType,
2625
EnvGroupResponse,
2726
WorkflowsResponseType,
2827
} from './AppGroup.types'

src/components/ApplicationGroup/CreateAppGroup.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import { toast } from 'react-toastify'
2121
import { createEnvGroup } from './AppGroup.service'
2222
import { useParams } from 'react-router-dom'
2323
import Tippy from '@tippyjs/react'
24-
import { filter } from 'rxjs'
2524

2625
export default function CreateAppGroup({
2726
appList,

src/components/app/details/AppHeader.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,10 @@ import { ReactComponent as Settings } from '../../../assets/icons/ic-settings.sv
1010
import PageHeader from '../../common/header/PageHeader'
1111
import { importComponentFromFELibrary, trackByGAEvent } from '../../common/helpers/Helpers'
1212
import AppGroupAppFilter from '../../ApplicationGroup/AppGroupAppFilter'
13+
import { AppGroupAppFilterContext } from '../../ApplicationGroup/AppGroupDetailsRoute'
14+
import { FilterParentType } from '../../ApplicationGroup/AppGroup.types'
1315
import './appDetails/appDetails.scss'
1416
import './app.scss'
15-
import { AppGroupAppFilterContext } from '../../ApplicationGroup/AppGroupDetailsRoute'
16-
import { CreateGroupAppListType, FilterParentType, GroupOptionType } from '../../ApplicationGroup/AppGroup.types'
17-
import CreateAppGroup from '../../ApplicationGroup/CreateAppGroup'
1817

1918
const MandatoryTagWarning = importComponentFromFELibrary('MandatoryTagWarning')
2019

src/components/app/details/main.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import './app.scss'
2222
import { MultiValue } from 'react-select'
2323
import { AppFilterTabs } from '../../ApplicationGroup/Constants'
2424
import {
25-
CheckPermissionType,
2625
CreateGroupAppListType,
2726
FilterParentType,
2827
GroupOptionType,
@@ -43,7 +42,7 @@ const TestRunList = lazy(() => import('./testViewer/TestRunList'))
4342

4443
export default function AppDetailsPage({ isV2 }: AppDetailsProps) {
4544
const { path } = useRouteMatch()
46-
const { appId, envId } = useParams<{ appId; envId }>()
45+
const { appId } = useParams<{ appId; }>()
4746
const [appName, setAppName] = useState('')
4847
const [appMetaInfo, setAppMetaInfo] = useState<AppMetaInfo>()
4948
const [reloadMandatoryProjects, setReloadMandatoryProjects] = useState<boolean>(true)

0 commit comments

Comments
 (0)