Skip to content

Commit 7d9c134

Browse files
authored
Merge pull request #1549 from devtron-labs/fix-for-missing-labels-without-callback
fix: missing labels due to missing callback
2 parents 68dbc7a + 1e01e15 commit 7d9c134

File tree

4 files changed

+21
-9
lines changed

4 files changed

+21
-9
lines changed

src/components/ciPipeline/Webhook/WebhookDetailsModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ export function WebhookDetailsModal({ close }: WebhookDetailType) {
365365
<div className="flexbox w-100 dc__position-rel en-2 bw-1 br-4 h-32">
366366
<CustomInput
367367
name="api-token"
368-
label={renderWebhhokTokenLabel}
368+
label={renderWebhhokTokenLabel()}
369369
placeholder="Enter API token"
370370
rootClassName="bcn-0 dc__no-border"
371371
onChange={handleTokenChange}

src/components/cluster/ClusterForm.tsx

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@ export default function ClusterForm({
670670
value={state.url.value}
671671
error={state.url.error}
672672
onChange={handleOnChange}
673-
label={clusterLabel}
673+
label={clusterLabel()}
674674
disabled={isDefaultCluster()}
675675
placeholder="Enter server URL"
676676
dataTestid="enter_server_url_input"
@@ -687,8 +687,8 @@ export default function ClusterForm({
687687
? id !== 1
688688
? DEFAULT_SECRET_PLACEHOLDER
689689
: config?.bearer_token
690-
? config.bearer_token
691-
: ''
690+
? config.bearer_token
691+
: ''
692692
: state.token.value
693693
}
694694
onChange={handleOnChange}
@@ -710,7 +710,9 @@ export default function ClusterForm({
710710
<>
711711
<hr />
712712
<div className="dc__position-rel dc__hover mb-20">
713-
<span className="form__input-header pb-20">How do you want Devtron to connect with this cluster?</span>
713+
<span className="form__input-header pb-20">
714+
How do you want Devtron to connect with this cluster?
715+
</span>
714716
<span className="pb-20">
715717
<KubectlConnectionRadio
716718
toConnectViaProxy={isConnectedViaProxyTemp}
@@ -719,8 +721,18 @@ export default function ClusterForm({
719721
changeSSHAuthenticationType={changeSSHAuthenticationType}
720722
proxyUrl={state.proxyUrl}
721723
sshTunnelUser={state.sshTunnelUser}
722-
sshTunnelPassword={(SSHConnectionType === SSHAuthenticationType.Password || SSHConnectionType === SSHAuthenticationType.Password_And_SSH_Private_Key) ? state.sshTunnelPassword : {value: '', error: ''}}
723-
sshTunnelPrivateKey={(SSHConnectionType === SSHAuthenticationType.SSH_Private_Key || SSHConnectionType === SSHAuthenticationType.Password_And_SSH_Private_Key) ? state.sshTunnelPrivateKey : {value: '', error: ''}}
724+
sshTunnelPassword={
725+
SSHConnectionType === SSHAuthenticationType.Password ||
726+
SSHConnectionType === SSHAuthenticationType.Password_And_SSH_Private_Key
727+
? state.sshTunnelPassword
728+
: { value: '', error: '' }
729+
}
730+
sshTunnelPrivateKey={
731+
SSHConnectionType === SSHAuthenticationType.SSH_Private_Key ||
732+
SSHConnectionType === SSHAuthenticationType.Password_And_SSH_Private_Key
733+
? state.sshTunnelPrivateKey
734+
: { value: '', error: '' }
735+
}
724736
sshTunnelUrl={state.sshTunnelUrl}
725737
handleOnChange={handleOnChange}
726738
/>

src/components/material/MaterialView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -526,7 +526,7 @@ export class MaterialView extends Component<MaterialViewProps, MaterialViewState
526526
</div>
527527
<div>
528528
<CustomInput
529-
label={this.renderGitRepoUrlLabel}
529+
label={this.renderGitRepoUrlLabel()}
530530
name="Git Repo URL"
531531
placeholder={this.gitAuthType('placeholder')}
532532
value={`${this.props.material.url}`}

src/components/notifications/SESConfigModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ export class SESConfigModal extends Component<SESConfigModalProps, SESConfigModa
303303
/>
304304
</label>
305305
<div className="form__row">
306-
<label htmlFor="" className="form__label dc__reuired-field">
306+
<label htmlFor="" className="form__label dc__required-field">
307307
AWS Region
308308
</label>
309309
<ReactSelect

0 commit comments

Comments
 (0)