Skip to content

Commit 81e5fba

Browse files
committed
code refactoring
1 parent e7ad287 commit 81e5fba

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

src/components/app/details/triggerView/cdMaterial.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2126,7 +2126,7 @@ const getInitialSelectedConfigToDeploy = () => {
21262126
diffOptions={state.diffOptions}
21272127
isRollbackTriggerSelected={state.isRollbackTrigger}
21282128
isRecentConfigAvailable={state.recentDeploymentConfig !== null}
2129-
canReviewConfig={canReviewConfig}
2129+
canReviewConfig={showConfigDiffView && canReviewConfig()}
21302130
/>
21312131
)
21322132
}

src/components/app/details/triggerView/triggerViewConfigDiff/TriggerViewConfigDiff.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export default function TriggerViewConfigDiff({
5656
const [currentData, setCurrentData] = useState<any>({}) // store codeEditorValue of current(lhs) and base(rhs) config
5757

5858
useEffect(() => {
59-
if (canReviewConfig() && searchParams.config && searchParams.deploy) {
59+
if (canReviewConfig) {
6060
const newSearchParams = {
6161
...searchParams,
6262
config: searchParams.config?.replace('-', '/'),
@@ -69,7 +69,7 @@ export default function TriggerViewConfigDiff({
6969
//handling the case when the user directly lands on the deployment history page
7070
handleNavOptionSelection(null, configParamValue)
7171
}
72-
}, [canReviewConfig(), searchParams.config , searchParams.deploy])
72+
}, [canReviewConfig])
7373

7474
useEffect(() => {
7575
handleConfigToDeploySelection()

src/components/app/details/triggerView/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,7 @@ export interface TriggerViewConfigDiffProps {
667667
diffOptions: Record<string, boolean>
668668
isRollbackTriggerSelected: boolean
669669
isRecentConfigAvailable: boolean
670-
canReviewConfig: () => boolean
670+
canReviewConfig: boolean
671671
}
672672

673673
export const MATERIAL_TYPE = {

0 commit comments

Comments
 (0)