Skip to content

Commit 86dd9c8

Browse files
authored
Merge pull request #2769 from devtron-labs/add-gitlab
feat: add gitlab in container registry provider option
2 parents d52e6fb + d7a3871 commit 86dd9c8

File tree

5 files changed

+21
-17
lines changed

5 files changed

+21
-17
lines changed

Dockerfile

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
1-
FROM node:22-alpine AS builder
1+
FROM node:20-alpine AS builder
22

3-
WORKDIR /app
4-
5-
RUN corepack enable yarn && \
6-
yarn set version 4.9.2
3+
RUN apk add --no-cache git
74

5+
WORKDIR /app
86
COPY package.json .
97
COPY yarn.lock .
10-
COPY .yarn/ .yarn/
11-
COPY .yarnrc.yml ./
128

13-
RUN apk add --no-cache git
14-
RUN yarn install --immutable --network-timeout 600000
9+
RUN yarn install --frozen-lockfile --network-timeout 600000
1510

11+
COPY src/ src
12+
COPY nginx.conf .
13+
COPY tsconfig.json .
14+
COPY vite.config.mts .
1615
COPY . .
1716

1817
RUN echo `git rev-parse --short=9 HEAD` > health.html && \
@@ -21,7 +20,7 @@ RUN echo `git rev-parse --short=9 HEAD` > health.html && \
2120

2221
RUN yarn build
2322

24-
FROM nginx:stable
23+
FROM fholzer/nginx-brotli:v1.26.2
2524

2625
RUN useradd -ms /bin/bash devtron
2726
COPY --from=builder /app/dist/ /usr/share/nginx/html

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"homepage": "/dashboard",
66
"dependencies": {
7-
"@devtron-labs/devtron-fe-common-lib": "1.16.0-pre-6",
7+
"@devtron-labs/devtron-fe-common-lib": "1.16.0-pre-7",
88
"@esbuild-plugins/node-globals-polyfill": "0.2.3",
99
"@rjsf/core": "^5.13.3",
1010
"@rjsf/utils": "^5.13.3",

src/components/dockerRegistry/Docker.tsx

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -804,7 +804,8 @@ const DockerForm = ({
804804
...(registryStorageType !== RegistryStorageType.OCI_PUBLIC &&
805805
(selectedDockerRegistryType.value === RegistryType.DOCKER_HUB ||
806806
selectedDockerRegistryType.value === RegistryType.ACR ||
807-
selectedDockerRegistryType.value === RegistryType.QUAY)
807+
selectedDockerRegistryType.value === RegistryType.QUAY ||
808+
selectedDockerRegistryType.value === RegistryType.GITLAB)
808809
? {
809810
username: trimmedUsername,
810811
password: parsePassword(customState.password.value),
@@ -1014,6 +1015,7 @@ const DockerForm = ({
10141015
break
10151016
case RegistryType.ACR:
10161017
case RegistryType.QUAY:
1018+
case RegistryType.GITLAB:
10171019
case RegistryType.OTHER:
10181020
let error = false
10191021
if (
@@ -1656,6 +1658,7 @@ const DockerForm = ({
16561658
{(selectedDockerRegistryType.value === RegistryType.DOCKER_HUB ||
16571659
selectedDockerRegistryType.value === RegistryType.ACR ||
16581660
selectedDockerRegistryType.value === RegistryType.QUAY ||
1661+
selectedDockerRegistryType.value === RegistryType.GITLAB ||
16591662
selectedDockerRegistryType.value === RegistryType.OTHER) && (
16601663
<PasswordField
16611664
shouldShowDefaultPlaceholderOnBlur={!!id && !!username}
@@ -1722,6 +1725,7 @@ const DockerForm = ({
17221725
{(selectedDockerRegistryType.value === RegistryType.DOCKER_HUB ||
17231726
selectedDockerRegistryType.value === RegistryType.ACR ||
17241727
selectedDockerRegistryType.value === RegistryType.QUAY ||
1728+
selectedDockerRegistryType.value === RegistryType.GITLAB ||
17251729
selectedDockerRegistryType.value === RegistryType.OTHER) && (
17261730
<PasswordField
17271731
shouldShowDefaultPlaceholderOnBlur={!!id}

src/config/constants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -481,6 +481,7 @@ export const RegistryType = {
481481
ECR: 'ecr',
482482
ARTIFACT_REGISTRY: 'artifact-registry',
483483
GCR: 'gcr',
484+
GITLAB: 'gitlab',
484485
}
485486

486487
export const RegistryTypeName = {

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1722,9 +1722,9 @@ __metadata:
17221722
languageName: node
17231723
linkType: hard
17241724

1725-
"@devtron-labs/devtron-fe-common-lib@npm:1.16.0-pre-6":
1726-
version: 1.16.0-pre-6
1727-
resolution: "@devtron-labs/devtron-fe-common-lib@npm:1.16.0-pre-6"
1725+
"@devtron-labs/devtron-fe-common-lib@npm:1.16.0-pre-7":
1726+
version: 1.16.0-pre-7
1727+
resolution: "@devtron-labs/devtron-fe-common-lib@npm:1.16.0-pre-7"
17281728
dependencies:
17291729
"@codemirror/autocomplete": "npm:6.18.6"
17301730
"@codemirror/lang-json": "npm:6.0.1"
@@ -1773,7 +1773,7 @@ __metadata:
17731773
react-select: 5.8.0
17741774
rxjs: ^7.8.1
17751775
yaml: ^2.4.1
1776-
checksum: 10c0/ad839d7b036e5d1e8fea2cd6733c2fc70090916b7cc7d2058c5302ab007a9f88cfedd8aafb5adb44cc9a0ea16a09801bbaabdbd8c68767c77bd6e0743a6791dd
1776+
checksum: 10c0/c76ae2146e8949d75a8ebf402117e362de6adec52950b08b89e811620646928cdaa73d1324600412a36d52d9d569ecb3a38991d25d29b26086e7b9ecd1981229
17771777
languageName: node
17781778
linkType: hard
17791779

@@ -5685,7 +5685,7 @@ __metadata:
56855685
version: 0.0.0-use.local
56865686
resolution: "dashboard@workspace:."
56875687
dependencies:
5688-
"@devtron-labs/devtron-fe-common-lib": "npm:1.16.0-pre-6"
5688+
"@devtron-labs/devtron-fe-common-lib": "npm:1.16.0-pre-7"
56895689
"@esbuild-plugins/node-globals-polyfill": "npm:0.2.3"
56905690
"@playwright/test": "npm:^1.32.1"
56915691
"@rjsf/core": "npm:^5.13.3"

0 commit comments

Comments
 (0)