Skip to content

Commit 89113b1

Browse files
authored
Merge branch 'develop' into feat/app-details-filters
2 parents 2b8cdea + 7f70303 commit 89113b1

File tree

3 files changed

+16
-11
lines changed

3 files changed

+16
-11
lines changed

src/App.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,8 @@ export default function App() {
9898
}
9999
} else {
100100
didMountRef.current = true
101+
// Removing any toast explicitly due to race condition of offline toast for some users
102+
ToastManager.dismissToast(onlineToastRef.current)
101103
}
102104
}, [isOnline])
103105

src/components/ApplicationGroup/AppGroupDetailsRoute.tsx

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -204,16 +204,19 @@ export default function AppGroupDetailsRoute({ isSuperAdmin }: AppGroupAdminType
204204
setAppGroupListData(result)
205205
setDescription(result.description)
206206
if (result.apps?.length) {
207-
setAppListOptions(
208-
result.apps
209-
.map((app): OptionType => {
210-
return {
211-
value: `${app.appId}`,
212-
label: app.appName,
213-
}
214-
})
215-
.sort(sortOptionsByLabel),
216-
)
207+
const _appListOptions = result.apps
208+
.map((app): OptionType => {
209+
return {
210+
value: `${app.appId}`,
211+
label: app.appName,
212+
}
213+
})
214+
.sort(sortOptionsByLabel)
215+
216+
setAppListOptions(_appListOptions)
217+
if (selectedGroupFilter.length) {
218+
setSelectedAppList(_appListOptions.filter((app) => selectedGroupFilter[0].appIds.includes(+app.value)))
219+
}
217220
}
218221
setAppListLoading(false)
219222
}

src/components/app/details/triggerView/CiWebhookDebuggingModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ export default function CiWebhookModal({
293293
className="mr-20 dc__transparent dc__align-right"
294294
onClick={() => onEditShowEditableCiModal(ciPipelineId, workflowId)}
295295
>
296-
// Here the CI model requires the CiPipelineId not the CiPipelineMaterialId
296+
{/* Here the CI model requires the CiPipelineId not the CiPipelineMaterialId */}
297297
<Edit className=" icon-dim-24" />
298298
</button>
299299
</div>

0 commit comments

Comments
 (0)