Skip to content

Commit 89e33bc

Browse files
committed
chore: lint docker args
1 parent 2ecea7a commit 89e33bc

File tree

1 file changed

+13
-3
lines changed

1 file changed

+13
-3
lines changed

src/components/CIPipelineN/DockerArgs.tsx

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,17 @@
1-
import React from 'react'
1+
import React, { FunctionComponent } from 'react'
22
import { TippyCustomized, TippyTheme, CustomInput } from '@devtron-labs/devtron-fe-common-lib'
33
import { DockerArgsAction, DockerArgsItemProps, DockerArgsProps } from './types'
44
import { ReactComponent as Close } from '../../assets/icons/ic-close.svg'
55
import { ReactComponent as QuestionIcon } from '../v2/assets/icons/ic-question.svg'
66
import { ReactComponent as HelpIcon } from '../../assets/icons/ic-help.svg'
77

8-
function DockerArgsItem({ arg, index, handleDockerArgsUpdate, fromBuildPack, readOnly }: DockerArgsItemProps) {
8+
const DockerArgsItem: FunctionComponent<DockerArgsItemProps> = ({
9+
arg,
10+
index,
11+
handleDockerArgsUpdate,
12+
fromBuildPack,
13+
readOnly,
14+
}) => {
915
const handleDockerArgKeyUpdate = (event: React.ChangeEvent<HTMLInputElement>) => {
1016
const argData = {
1117
index,
@@ -62,6 +68,7 @@ function DockerArgsItem({ arg, index, handleDockerArgsUpdate, fromBuildPack, rea
6268
className="dc__no-background flexbox dc__align-start dc__no-border dc__outline-none-imp"
6369
onClick={handleRemoveDockerArg}
6470
type="button"
71+
aria-label="remove-docker-args"
6572
>
6673
<Close className="icon-dim-24 mt-6 ml-6" />
6774
</button>
@@ -70,7 +77,7 @@ function DockerArgsItem({ arg, index, handleDockerArgsUpdate, fromBuildPack, rea
7077
)
7178
}
7279

73-
export default function DockerArgs({ args, handleDockerArgsUpdate, fromBuildPack, readOnly }: DockerArgsProps) {
80+
const DockerArgs: FunctionComponent<DockerArgsProps> = ({ args, handleDockerArgsUpdate, fromBuildPack, readOnly }) => {
7481
const handleAddDockerArgs = () => {
7582
handleDockerArgsUpdate({ action: DockerArgsAction.ADD })
7683
}
@@ -125,6 +132,7 @@ export default function DockerArgs({ args, handleDockerArgsUpdate, fromBuildPack
125132
{args.length > 0 &&
126133
args.map((arg, index) => (
127134
<DockerArgsItem
135+
// eslint-disable-next-line react/no-array-index-key
128136
key={`build-${index}`}
129137
index={index}
130138
arg={arg}
@@ -136,3 +144,5 @@ export default function DockerArgs({ args, handleDockerArgsUpdate, fromBuildPack
136144
</div>
137145
)
138146
}
147+
148+
export default DockerArgs

0 commit comments

Comments
 (0)