Skip to content

Commit 8c4fd9f

Browse files
committed
code feedback fixes
1 parent fc5b46c commit 8c4fd9f

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

src/components/app/details/triggerView/cdMaterial.tsx

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,10 @@ export default function CDMaterial({
245245
checkingDiff: false,
246246
}))
247247
},
248-
).finally(() => {
248+
).catch((error) => {
249+
showError(error)
250+
})
251+
.finally(() => {
249252
setState((prevState) => ({ ...prevState, checkingDiff: false }))
250253
})
251254
}
@@ -819,7 +822,7 @@ const getInitialSelectedConfigToDeploy = () => {
819822
}
820823

821824
const handleConfigSelection = (selected) => {
822-
if (selected?.value !== state.selectedConfigToDeploy.value) {
825+
if (selected.value !== state.selectedConfigToDeploy.value) {
823826
const _diffOptions = checkForDiff(state.recentDeploymentConfig, getBaseTemplateConfiguration(selected))
824827
setState((prevState) => ({
825828
...prevState,

src/components/app/details/triggerView/triggerViewConfigDiff/TriggerViewConfigDiff.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,11 @@ export default function TriggerViewConfigDiff({
6262
config: searchParams.config?.replace('-', '/'),
6363
deploy: searchParams.deploy,
6464
}
65-
const configParamValue = searchParams.config?.replace('-', '/')
6665
history.push({
6766
search: new URLSearchParams(newSearchParams).toString(),
6867
})
6968
//handling the case when the user directly lands on the deployment history page
70-
handleNavOptionSelection(null, configParamValue)
69+
handleNavOptionSelection(null, newSearchParams.config)
7170
}
7271
}, [canReviewConfig])
7372

0 commit comments

Comments
 (0)