Skip to content

Commit 8ca8a86

Browse files
Elessar1802Elessar1802
committed
fix: sonarqube issues
1 parent 159411f commit 8ca8a86

File tree

2 files changed

+37
-36
lines changed

2 files changed

+37
-36
lines changed

‎src/components/bulkEdits/BulkEdits.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ const BULK_EDIT_VALIDATOR_SCHEMA = importComponentFromFELibrary('BULK_EDIT_VALID
7373
export const getBulkEditConfig = importComponentFromFELibrary('getBulkEditConfig', null, 'function')
7474

7575
class BulkEdits extends Component<BulkEditsProps, BulkEditsState> {
76-
private editorAndOutputContainerRef = createRef<HTMLDivElement>()
76+
private readonly editorAndOutputContainerRef = createRef<HTMLDivElement>()
7777

7878
constructor(props: BulkEditsProps) {
7979
super(props)

‎src/components/bulkEdits/bulkedit.utils.tsx

Lines changed: 36 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
import React from 'react'
1718
import { CMandSecretImpactedObjects, DtOutputKeys, OutputTabType, CMandSecretOutputKeys } from './bulkEdits.type'
1819
import { OutputDivider } from './constants'
1920

@@ -31,12 +32,12 @@ export const OutputTabs: React.FC<OutputTabType> = ({ handleOutputTabs, outputNa
3132
const renderCmAndSecretResponseForOneApp = (CMandSecretOutputKeys: CMandSecretOutputKeys) => {
3233
return (
3334
<div>
34-
{CMandSecretOutputKeys.appId && <>App Id: {CMandSecretOutputKeys.appId} <br /></>}
35-
{CMandSecretOutputKeys.appName && <>App Name: {CMandSecretOutputKeys.appName} <br /></>}
36-
{CMandSecretOutputKeys.envId && <>Environment Id: {CMandSecretOutputKeys.envId} <br /></>}
37-
{CMandSecretOutputKeys.envName && <>Environment Name: {CMandSecretOutputKeys.envName} <br /></>}
38-
{CMandSecretOutputKeys.names && <>Names : {CMandSecretOutputKeys.names.join(', ')} <br /></>}
39-
{CMandSecretOutputKeys.message && <>Message: {CMandSecretOutputKeys.message} <br /></>}
35+
{!!CMandSecretOutputKeys.appId && <>App Id: {CMandSecretOutputKeys.appId} <br /></>}
36+
{!!CMandSecretOutputKeys.appName && <>App Name: {CMandSecretOutputKeys.appName} <br /></>}
37+
{!!CMandSecretOutputKeys.envId && <>Environment Id: {CMandSecretOutputKeys.envId} <br /></>}
38+
{!!CMandSecretOutputKeys.envName && <>Environment Name: {CMandSecretOutputKeys.envName} <br /></>}
39+
{CMandSecretOutputKeys.names && CMandSecretOutputKeys.names.length > 0 && <>Names : {CMandSecretOutputKeys.names.join(', ')} <br /></>}
40+
{!!CMandSecretOutputKeys.message && <>Message: {CMandSecretOutputKeys.message} <br /></>}
4041
<br />
4142
</div>
4243
)
@@ -52,12 +53,12 @@ export const renderConfigMapOutput = (configMap) => {
5253
<div>
5354
#Message: <br />
5455
<br />
55-
{configMap.message?.map((elm) => {
56+
{configMap.message?.map((elm, index) => {
5657
return (
57-
<>
58+
<React.Fragment key={index}>
5859
{elm}
5960
<br />
60-
</>
61+
</React.Fragment>
6162
)
6263
})}
6364
</div>
@@ -71,8 +72,8 @@ export const renderConfigMapOutput = (configMap) => {
7172
<>No Result Found</>
7273
) : (
7374
<>
74-
{configMap.failure.map((elm) => {
75-
return renderCmAndSecretResponseForOneApp(elm)
75+
{configMap.failure.map((elm, index) => {
76+
return <React.Fragment key={index}>{renderCmAndSecretResponseForOneApp(elm)}</React.Fragment>
7677
})}
7778
</>
7879
)}
@@ -86,8 +87,8 @@ export const renderConfigMapOutput = (configMap) => {
8687
<>No Result Found</>
8788
) : (
8889
<>
89-
{configMap.successful.map((elm) => {
90-
return renderCmAndSecretResponseForOneApp(elm)
90+
{configMap.successful.map((elm, index) => {
91+
return <React.Fragment key={index}>{renderCmAndSecretResponseForOneApp(elm)}</React.Fragment>
9192
})}
9293
</>
9394
)}
@@ -100,11 +101,11 @@ export const renderConfigMapOutput = (configMap) => {
100101
export const renderDTResponseForOneApp = (DTOutputKeys: DtOutputKeys) => {
101102
return (
102103
<div>
103-
{DTOutputKeys.appId && <>App Id: {DTOutputKeys.appId} <br /></>}
104-
{DTOutputKeys.appName && <>App Name: {DTOutputKeys.appName} <br /></>}
105-
{DTOutputKeys.envId && <>Environment Id: {DTOutputKeys.envId} <br /></>}
106-
{DTOutputKeys.envName && <>Environment Name: {DTOutputKeys.envName} <br /></>}
107-
{DTOutputKeys.message && <>Message: {DTOutputKeys.message} <br /></>}
104+
{!!DTOutputKeys.appId && <>App Id: {DTOutputKeys.appId} <br /></>}
105+
{!!DTOutputKeys.appName && <>App Name: {DTOutputKeys.appName} <br /></>}
106+
{!!DTOutputKeys.envId && <>Environment Id: {DTOutputKeys.envId} <br /></>}
107+
{!!DTOutputKeys.envName && <>Environment Name: {DTOutputKeys.envName} <br /></>}
108+
{!!DTOutputKeys.message && <>Message: {DTOutputKeys.message} <br /></>}
108109
<br />
109110
</div>
110111
)
@@ -113,10 +114,10 @@ export const renderDTResponseForOneApp = (DTOutputKeys: DtOutputKeys) => {
113114
export const renderCMAndSecretImpObj = (CMandSecretImpactedObject: CMandSecretImpactedObjects) => {
114115
return (
115116
<div>
116-
{CMandSecretImpactedObject.appId && <>App Id: {CMandSecretImpactedObject.appId} <br /></>}
117-
{CMandSecretImpactedObject.appName && <>App Name: {CMandSecretImpactedObject.appName} <br /></>}
118-
{CMandSecretImpactedObject.envId && <>Environment Id: {CMandSecretImpactedObject.envId} <br /></>}
119-
{CMandSecretImpactedObject.envName && <>Environment Name: {CMandSecretImpactedObject.envName} <br /></>}
117+
{!!CMandSecretImpactedObject.appId && <>App Id: {CMandSecretImpactedObject.appId} <br /></>}
118+
{!!CMandSecretImpactedObject.appName && <>App Name: {CMandSecretImpactedObject.appName} <br /></>}
119+
{!!CMandSecretImpactedObject.envId && <>Environment Id: {CMandSecretImpactedObject.envId} <br /></>}
120+
{!!CMandSecretImpactedObject.envName && <>Environment Name: {CMandSecretImpactedObject.envName} <br /></>}
120121
{CMandSecretImpactedObject.names && CMandSecretImpactedObject.names.length > 0 && <>Names : {CMandSecretImpactedObject.names.join(', ')} <br /></>}
121122
<br />
122123
</div>
@@ -133,9 +134,9 @@ export const renderDeploymentTemplateOutput = (deploymentTemplate) => {
133134
<div>
134135
#Message: <br />
135136
<br />
136-
{deploymentTemplate.message?.map((elm) => {
137+
{deploymentTemplate.message?.map((elm, index) => {
137138
return (
138-
<div>
139+
<div key={index}>
139140
{elm}
140141
<br />
141142
</div>
@@ -152,8 +153,8 @@ export const renderDeploymentTemplateOutput = (deploymentTemplate) => {
152153
<>No Result Found</>
153154
) : (
154155
<>
155-
{deploymentTemplate.failure.map((elm) => {
156-
return renderDTResponseForOneApp(elm)
156+
{deploymentTemplate.failure.map((elm, index) => {
157+
return <React.Fragment key={index}>{renderDTResponseForOneApp(elm)}</React.Fragment>
157158
})}
158159
</>
159160
)}
@@ -168,8 +169,8 @@ export const renderDeploymentTemplateOutput = (deploymentTemplate) => {
168169
<>No Result Found</>
169170
) : (
170171
<>
171-
{deploymentTemplate.successful.map((elm) => {
172-
return renderDTResponseForOneApp(elm)
172+
{deploymentTemplate.successful.map((elm, index) => {
173+
return <React.Fragment key={index}>{renderDTResponseForOneApp(elm)}</React.Fragment>
173174
})}
174175
</>
175176
)}
@@ -189,12 +190,12 @@ export const renderSecretOutput = (secret) => {
189190
<div>
190191
#Message: <br />
191192
<br />
192-
{secret.message?.map((elm) => {
193+
{secret.message?.map((elm, index) => {
193194
return (
194-
<>
195+
<React.Fragment key={index}>
195196
{elm}
196197
<br />
197-
</>
198+
</React.Fragment>
198199
)
199200
})}
200201
</div>
@@ -208,8 +209,8 @@ export const renderSecretOutput = (secret) => {
208209
<>No Result Found</>
209210
) : (
210211
<>
211-
{secret.failure.map((elm) => {
212-
return renderCmAndSecretResponseForOneApp(elm)
212+
{secret.failure.map((elm, index) => {
213+
return <React.Fragment key={index}>{renderCmAndSecretResponseForOneApp(elm)}</React.Fragment>
213214
})}
214215
</>
215216
)}
@@ -224,8 +225,8 @@ export const renderSecretOutput = (secret) => {
224225
<>No Result Found</>
225226
) : (
226227
<>
227-
{secret.successful.map((elm) => {
228-
return renderCmAndSecretResponseForOneApp(elm)
228+
{secret.successful.map((elm, index) => {
229+
return <React.Fragment key={index}>{renderCmAndSecretResponseForOneApp(elm)}</React.Fragment>
229230
})}
230231
</>
231232
)}

0 commit comments

Comments
 (0)