Refactored after review

Author: Badal Kumar Prusty

.github/workflows/pr-issue-validator.yaml

@@ -32,7 +32,7 @@ jobs:
       run: |
         set -x    
         # Skip validation for documentation or chore PRs
-        if [[ "$TITLE" =~ ^(doc:|docs:|chore:) ]]; then
+        if [[ "$TITLE" =~ ^(doc:|docs:|chore:|misc:) ]]; then
           echo "Skipping validation for docs/chore PR."
           echo "PR NUMBER-: $PRNUM "
           gh pr edit $PRNUM --remove-label "PR:Issue-verification-failed"
@@ -54,17 +54,26 @@ jobs:
 
         # Extract issue number and repo from PR body
         extract_issue_number() {
-          local pattern="$1"
+          local pattern="$1"  # Get the pattern as the first argument to the function
+
+          # Check if PR_BODY matches the provided pattern using Bash's =~ regex operator
           if [[ "$PR_BODY" =~ $pattern ]]; then
             echo "matched for this pattern $pattern"
-            issue_num=$(echo "${BASH_REMATCH[0]}" | grep -oE "[0-9]+" | tr -d '\r\n')
+
+            # # If there is a match, Bash populates the BASH_REMATCH array with the results. stores the entire matched portion of the string
+            # issue_num=$(echo "${BASH_REMATCH[0]}" | grep -oE "[0-9]+" | tr -d '\r\n')
+            
+            issue_num=$(echo "$PR_BODY" | grep -oE "$pattern" | grep -oE "[0-9]+")
+
+            # Extract the repository name (e.g., devtron-labs/devtron) from PR_BODY using grep
             repo=$(echo "$PR_BODY" | grep -oE "devtron-labs/[a-zA-Z0-9_-]+")
             echo "Extracted issue number: $issue_num from repo: $repo"
-            return 0
+
+            return 0  # Return success
           else
             echo "No match for the pattern $pattern"
           fi
-          return 1
+          return 1  # Return failure if no match
         }
 
         issue_num=""
@@ -92,11 +101,33 @@ jobs:
 
         if [[ "$response_code" -eq 200 ]]; then
           echo "Issue #$issue_num is valid and exists in $repo."
-          gh pr edit $PRNUM --remove-label "PR:Issue-verification-failed"
-          gh pr edit $PRNUM --add-label "PR:Ready-to-Review"
+
+          # Fetch the current state of the issue (open/closed) from the private repository.
+          issue_status=$(curl -s \
+            --header "authorization: Bearer ${{ secrets.GH_PR_VALIDATOR_TOKEN }}" \
+            "$issue_api_url" | jq '.state')
+          # Check if the issue is still open.
+          if [[ "$issue_status" -eq "open" ]]; then
+            echo "Issue #$issue_num is opened."
+            # Remove the 'Issue-verification-failed' label (if present) and add 'Ready-to-Review'.
+            gh pr edit $PRNUM --remove-label "PR:Issue-verification-failed"
+            gh pr edit $PRNUM --add-label "PR:Ready-to-Review"
+          else
+            echo "Issue #$issue_num is closed. Please link an open issue to proceed."
+            # Add a comment to the PR indicating the issue is not linked correctly.
+            gh pr comment $PRNUM --body "PR is  linked to a closed issue. Please link an open issue to proceed."
+
+            # Add the 'Issue-verification-failed' label and remove 'Ready-to-Review'.
+            gh pr edit $PRNUM --add-label "PR:Issue-verification-failed"
+            gh pr edit $PRNUM --remove-label "PR:Ready-to-Review"
+            exit 1
+          fi
         else
           echo "Issue not found. Invalid URL or issue number."
-          gh pr comment $PRNUM --body "PR is not linked to a valid issue. Please update."
+          # Add a comment to the PR indicating the issue is not linked correctly.
+          gh pr comment $PRNUM --body "PR is not linked to a valid issue. Please update the issue link."
+          
+          # Apply 'Issue-verification-failed' label and remove 'Ready-to-Review' label.
           gh pr edit $PRNUM --add-label "PR:Issue-verification-failed"
           gh pr edit $PRNUM --remove-label "PR:Ready-to-Review"
           exit 1