Skip to content

Commit 922c876

Browse files
committed
refactor: remove helmAppPackageName state and update related components to use deployment.helmPackageName
1 parent 123a44b commit 922c876

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

src/components/v2/chartDeploymentHistory/ChartDeploymentHistory.component.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,12 @@ const ChartDeploymentHistory = ({
8585
isExternal,
8686
isVirtualEnvironment,
8787
isLoadingDetails,
88-
helmAppPackageName,
8988
}: {
9089
appId: string
9190
appName?: string
9291
isExternal: boolean
9392
isVirtualEnvironment?: boolean
9493
isLoadingDetails?: boolean
95-
helmAppPackageName?: string
9694
}) => {
9795
const params = useParams<{ envId: string }>()
9896
const [isLoading, setIsLoading] = useState(true)
@@ -503,7 +501,7 @@ const ChartDeploymentHistory = ({
503501
const paramsData = {
504502
appId,
505503
envId: params.envId,
506-
appName: helmAppPackageName,
504+
appName: deployment.helmPackageName,
507505
workflowId: deployment.version,
508506
isHelmApp: true,
509507
}
@@ -603,7 +601,7 @@ const ChartDeploymentHistory = ({
603601
renderCodeEditor()}
604602
{selectedDeploymentTabName === DEPLOYMENT_HISTORY_TAB.ARTIFACTS && VirtualHistoryArtifact && (
605603
<VirtualHistoryArtifact
606-
titleName={helmAppPackageName}
604+
titleName={deployment.helmPackageName}
607605
params={paramsData}
608606
status={deployment.status}
609607
/>

src/components/v2/chartDeploymentHistory/chartDeploymentHistory.service.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ export interface ChartDeploymentDetail {
4444
deployedBy: string
4545
status: string
4646
message?: string
47+
helmPackageName?: string
4748
}
4849

4950
export interface RollbackReleaseRequest {

src/components/v2/index.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ const RouterComponent = ({ envType }) => {
5252
})
5353
const [loadingDetails, setLoadingDetails] = useState(false)
5454
const [loadingResourceTree, setLoadingResourceTree] = useState(false)
55-
const [helmAppPackageName, setHelmAppPackageName] = useState('')
5655
// NOTE: this might seem like a duplicate of loadingResourceTree
5756
// but its not since loadingResourceTree runs a loader on the whole page
5857
// maybe we can rename loadingResourceTree
@@ -128,7 +127,6 @@ const RouterComponent = ({ envType }) => {
128127
.then((response) => {
129128
handlePublishAppDetails(response)
130129
isVirtualRef.current = response.result?.isVirtualEnvironment
131-
setHelmAppPackageName(response.result?.helmPackageName)
132130
if (fetchExternalLinks) {
133131
getExternalLinksAndTools(response.result?.clusterId)
134132
}
@@ -253,7 +251,6 @@ const RouterComponent = ({ envType }) => {
253251
isExternal={false}
254252
isLoadingDetails={loadingDetails}
255253
isVirtualEnvironment={isVirtualRef.current}
256-
helmAppPackageName={helmAppPackageName}
257254
/>
258255
</Route>
259256
<Redirect to={`${path}/${URLS.APP_DETAILS}`} />

0 commit comments

Comments
 (0)