Skip to content

Commit 93c46c6

Browse files
committed
feat: add support for strategy change diff in deployment history
1 parent 3379670 commit 93c46c6

File tree

9 files changed

+5
-266
lines changed

9 files changed

+5
-266
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,6 @@ src/components/app/details/appDetails/utils.tsx
9292
src/components/app/details/cIDetails/CIDetails.tsx
9393
src/components/app/details/cIDetails/cIDetails.util.tsx
9494
src/components/app/details/cdDetails/CDDetails.tsx
95-
src/components/app/details/cdDetails/service.ts
9695
src/components/app/details/cicdHistory/History.components.tsx
9796
src/components/app/details/main.tsx
9897
src/components/app/details/metrics/BenchmarkModal.tsx

src/components/ApplicationGroup/Details/EnvCDDetails/__mock__/EnvCDDetails.mock.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { ResponseType } from '@devtron-labs/devtron-fe-common-lib'
18-
19-
import { ModuleConfigResponse } from '../../../../app/details/appDetails/appDetails.type'
17+
import { ModuleConfigResponse, ResponseType } from '@devtron-labs/devtron-fe-common-lib'
2018

2119
export async function mockCDList(): Promise<ResponseType> {
2220
const response = {

src/components/app/details/appDetails/appDetails.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import {
1818
DeploymentStatusDetailsResponse,
1919
get,
2020
getUrlWithSearchParams,
21+
ModuleConfigResponse,
2122
ResponseType,
2223
trash,
2324
} from '@devtron-labs/devtron-fe-common-lib'
@@ -30,7 +31,6 @@ import {
3031
DataSourceDetailsDTO,
3132
DataSourceDetailsQueryParams,
3233
DataSourceDetailsType,
33-
ModuleConfigResponse,
3434
} from './appDetails.type'
3535

3636
export const getDataSourceDetailsFromEnvironment = async (envName: string): Promise<DataSourceDetailsType> => {

src/components/app/details/appDetails/appDetails.type.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,6 @@ export interface AppDetailsPathParams {
6565
envId?: string
6666
}
6767

68-
export interface ModuleConfigResponse extends ResponseType {
69-
result?: {
70-
enabled: boolean
71-
}
72-
}
73-
7468
export interface DataSourceDetailsDTO {
7569
id: number
7670
name: string
@@ -92,18 +86,6 @@ export interface ClusterConnectionResponse extends ResponseType {
9286
}
9387
}
9488

95-
export type DeleteResponseType = {
96-
clusterName: string
97-
clusterReachable: boolean
98-
deleteInitiated: boolean
99-
}
100-
101-
export interface DeploymentStatusDetailRowType {
102-
type: string
103-
hideVerticalConnector?: boolean
104-
deploymentDetailedData: DeploymentStatusDetailsBreakdownDataType
105-
}
106-
10789
export type SocketConnectionType = 'CONNECTED' | 'CONNECTING' | 'DISCONNECTED' | 'DISCONNECTING'
10890

10991
export interface NodeSelectorsType {

src/components/app/details/cdDetails/cd.type.ts

Lines changed: 0 additions & 74 deletions
This file was deleted.

src/components/app/details/cdDetails/service.ts

Lines changed: 0 additions & 165 deletions
This file was deleted.

src/components/app/details/triggerView/PipelineConfigDiff/utils.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ export const getPipelineDeploymentConfigSelectorConfig = ({
109109
onChange: handleChangeDeploymentConfig,
110110
groupValue: deploy,
111111
},
112-
...(pipelineStrategyOptions.length && deploymentStrategy
112+
...(pipelineStrategyOptions.length > 1 && deploymentStrategy
113113
? [
114114
{
115115
title: 'Select strategy type',

src/components/app/details/triggerView/TriggerView.utils.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,11 @@
1616

1717
import { useLocation } from 'react-router-dom'
1818

19-
import { DeploymentWithConfigType } from '@devtron-labs/devtron-fe-common-lib'
19+
import { DeploymentHistoryDetail, DeploymentWithConfigType } from '@devtron-labs/devtron-fe-common-lib'
2020

2121
import { URLS } from '@Config/routes'
2222

2323
import { deepEqual } from '../../../common'
24-
import { DeploymentHistoryDetail } from '../cdDetails/cd.type'
2524
import { TRIGGER_VIEW_PARAMS } from './Constants'
2625
import { TriggerViewDeploymentConfigType } from './types'
2726

src/components/app/details/triggerView/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ import {
3232
CommonNodeAttr,
3333
ConsequenceType,
3434
DeploymentAppTypes,
35+
DeploymentHistoryDetail,
3536
DeploymentNodeType,
3637
DeploymentWithConfigType,
3738
DynamicDataTableCellValidationState,
@@ -52,7 +53,6 @@ import { EnvironmentWithSelectPickerType } from '@Components/CIPipelineN/types'
5253
import { AppContextType } from '@Components/common'
5354

5455
import { HostURLConfig } from '../../../../services/service.types'
55-
import { DeploymentHistoryDetail } from '../cdDetails/cd.type'
5656
import { Offset, WorkflowDimensions } from './config'
5757
import { TIME_STAMP_ORDER } from './Constants'
5858

0 commit comments

Comments
 (0)