chore: moved response list logic in service

Author: shivani170

src/Pages/App/CreateAppModal/AppClone/useDevtronCloneList.tsx

@@ -3,18 +3,13 @@
  */
 import { useEffect, useMemo, useRef, useState } from 'react'
 
-import {
-    abortPreviousRequests,
-    GenericInfoCardListingProps,
-    getIsRequestAborted,
-    useAsync,
-} from '@devtron-labs/devtron-fe-common-lib'
+import { abortPreviousRequests, getIsRequestAborted, useAsync } from '@devtron-labs/devtron-fe-common-lib'
 
 import { getJobs } from '@Components/Jobs/Service'
 import { APP_TYPE } from '@Config/constants'
-import { getAppIconWithBackground } from '@Config/utils'
 import { getAppListMin } from '@Services/service'
 
+import { getDevtronAppList } from '../service'
 import { DevtronAppCloneListProps, DevtronListResponse } from './types'
 
 export const useDevtronCloneList = ({ handleCloneAppClick, isJobView }: DevtronAppCloneListProps) => {
@@ -53,11 +48,11 @@ export const useDevtronCloneList = ({ handleCloneAppClick, isJobView }: DevtronA
         },
         [],
     )
-    let totalCount = 0
 
-    if (listResponse?.type === APP_TYPE.JOB) {
-        totalCount = listResponse.data.result.jobCount
-    }
+    const { list, totalCount } = useMemo(() => {
+        if (!listResponse) return { list: [], totalCount: 0 }
+        return getDevtronAppList({ listResponse, handleCloneAppClick })
+    }, [isListLoading, listResponse, handleCloneAppClick])
 
     const loadMoreData = async () => {
         if (isLoadingMore || !listResponse) return
@@ -101,43 +96,6 @@ export const useDevtronCloneList = ({ handleCloneAppClick, isJobView }: DevtronA
         }
     }
 
-    const list = useMemo(() => {
-        if (isListLoading || !listResponse) return []
-
-        if (listResponse.type === APP_TYPE.JOB) {
-            const jobContainers = listResponse.data.result?.jobContainers ?? []
-
-            totalCount = listResponse.data.result.jobCount
-
-            return jobContainers.map<GenericInfoCardListingProps['list'][number]>((job) => {
-                const { jobId, jobName, description } = job
-
-                return {
-                    id: String(jobId),
-                    title: jobName,
-                    description: description.description,
-                    author: description.createdBy,
-                    Icon: getAppIconWithBackground(APP_TYPE.JOB, 40),
-                    onClick: () => handleCloneAppClick({ appId: jobId, appName: jobName }),
-                }
-            })
-        }
-        const apps = listResponse.data.result ?? []
-
-        return apps.map<GenericInfoCardListingProps['list'][number]>((app) => {
-            const { id, name, createdBy, description } = app
-
-            return {
-                id: String(id),
-                title: name,
-                Icon: getAppIconWithBackground(APP_TYPE.DEVTRON_APPS, 40),
-                onClick: () => handleCloneAppClick({ appId: id, appName: name }),
-                author: createdBy,
-                description,
-            }
-        })
-    }, [isListLoading, listResponse])
-
     return {
         isListLoading: isListLoading ?? getIsRequestAborted(listError),
         list,

src/Pages/App/CreateAppModal/service.ts

@@ -14,8 +14,58 @@
  * limitations under the License.
  */
 
-import { post } from '@devtron-labs/devtron-fe-common-lib'
+import { BaseAppMetaData, GenericInfoCardListingProps, post } from '@devtron-labs/devtron-fe-common-lib'
 
-import { Routes } from '@Config/constants'
+import { APP_TYPE, Routes } from '@Config/constants'
+import { getAppIconWithBackground } from '@Config/utils'
+
+import { DevtronListResponse } from './AppClone/types'
 
 export const createApp = (request) => post(Routes.APP, request)
+
+export const getDevtronAppList = ({
+    listResponse,
+    handleCloneAppClick,
+}: {
+    listResponse: DevtronListResponse
+    handleCloneAppClick: (app: BaseAppMetaData) => void
+}) => {
+    if (listResponse.type === APP_TYPE.JOB) {
+        const jobContainers = listResponse.data.result?.jobContainers ?? []
+
+        const totalCount = listResponse.data.result.jobCount
+
+        return {
+            list: jobContainers.map<GenericInfoCardListingProps['list'][number]>((job) => {
+                const { jobId, jobName, description } = job
+
+                return {
+                    id: String(jobId),
+                    title: jobName,
+                    description: description.description,
+                    author: description.createdBy,
+                    Icon: getAppIconWithBackground(APP_TYPE.JOB, 40),
+                    onClick: () => handleCloneAppClick({ appId: jobId, appName: jobName }),
+                }
+            }),
+            totalCount,
+        }
+    }
+    const apps = listResponse.data.result ?? []
+
+    return {
+        list: apps.map<GenericInfoCardListingProps['list'][number]>((app) => {
+            const { id, name, createdBy, description } = app
+
+            return {
+                id: String(id),
+                title: name,
+                Icon: getAppIconWithBackground(APP_TYPE.DEVTRON_APPS, 40),
+                onClick: () => handleCloneAppClick({ appId: id, appName: name }),
+                author: createdBy,
+                description,
+            }
+        }),
+        totalCount: apps.length,
+    }
+}