Skip to content

Commit 94e9310

Browse files
authored
Merge pull request #2938 from devtron-labs/fix/issues
fix: multiple issues
2 parents 5334064 + f0a27a2 commit 94e9310

File tree

3 files changed

+23
-42
lines changed

3 files changed

+23
-42
lines changed

src/components/charts/list/DiscoverCharts.tsx

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import React, { useEffect, useMemo, useRef, useState } from 'react'
18-
import { NavLink, Prompt, Route, Switch, useHistory, useLocation, useRouteMatch } from 'react-router-dom'
18+
import { Prompt, Route, Switch, useHistory, useLocation, useRouteMatch } from 'react-router-dom'
1919
import Tippy from '@tippyjs/react'
2020

2121
import {
@@ -28,6 +28,7 @@ import {
2828
FeatureTitleWithInfo,
2929
getApplicationManagementBreadcrumb,
3030
handleAnalyticsEvent,
31+
InfoIconTippy,
3132
PageHeader,
3233
Progressing,
3334
showError,
@@ -327,13 +328,31 @@ const DiscoverChartList = ({ isSuperAdmin }: { isSuperAdmin: boolean }) => {
327328
alias: {
328329
...getApplicationManagementBreadcrumb(),
329330
'chart-store': null,
330-
discover: { component: 'Chart Store', linked: false },
331+
discover: {
332+
component: (
333+
<div className="flex left dc__gap-16">
334+
<div className="flex">
335+
<span>Chart Store</span>
336+
337+
<InfoIconTippy
338+
infoText={CHART_STORE_TIPPY_CONTENT}
339+
heading="Chart Store"
340+
iconClassName="icon-dim-20 ml-8 fcn-5"
341+
documentationLink="CHART_STORE"
342+
documentationLinkText="View Documentation"
343+
/>
344+
</div>
345+
346+
{isSuperAdmin && <ChartsList isLoading={isLoading} chartsList={chartsList} />}
347+
</div>
348+
),
349+
linked: false,
350+
},
331351
},
332352
},
333353
[],
334354
)
335355

336-
337356
const renderBreadcrumbs = () => {
338357
if (typeof state.configureChartIndex === 'number') {
339358
return (

src/components/common/helpers/workflowURL.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export function getCIPipelineURL(
5454
? generatePath(CommonURLS.APPLICATION_MANAGEMENT_TEMPLATES_DEVTRON_APP_DETAIL, {
5555
appId,
5656
})
57-
: `/${isJobView ? CommonURLS.AUTOMATION_AND_ENABLEMENT_JOB : CommonURLS.APPLICATION_MANAGEMENT_APP}/${appId}`
57+
: `${isJobView ? CommonURLS.AUTOMATION_AND_ENABLEMENT_JOB : CommonURLS.APPLICATION_MANAGEMENT_APP}/${appId}`
5858
}/edit/workflow/`
5959
}
6060
const ciPipelineSuffix = ciPipelineId ? `/${ciPipelineId}` : ''

src/css/patternfly.scss

Lines changed: 0 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -2382,44 +2382,6 @@ fieldset[disabled] .navbar-inverse .btn-link:focus {
23822382
border-top-right-radius: 1px;
23832383
border-bottom-right-radius: 1px;
23842384
}
2385-
.pager {
2386-
padding-left: 0;
2387-
margin: 20px 0;
2388-
text-align: center;
2389-
list-style: none;
2390-
}
2391-
.pager li {
2392-
display: inline;
2393-
}
2394-
.pager li > a,
2395-
.pager li > span {
2396-
display: inline-block;
2397-
padding: 5px 14px;
2398-
background-color: var(--N100);
2399-
border: 1px solid var(--N200);
2400-
border-radius: 0;
2401-
}
2402-
.pager li > a:hover,
2403-
.pager li > a:focus {
2404-
text-decoration: none;
2405-
background-color: var(--N100);
2406-
}
2407-
.pager .next > a,
2408-
.pager .next > span {
2409-
float: right;
2410-
}
2411-
.pager .previous > a,
2412-
.pager .previous > span {
2413-
float: left;
2414-
}
2415-
.pager .disabled > a,
2416-
.pager .disabled > a:hover,
2417-
.pager .disabled > a:focus,
2418-
.pager .disabled > span {
2419-
color: #8b8d8f;
2420-
cursor: not-allowed;
2421-
background-color: var(--N100);
2422-
}
24232385
.label {
24242386
display: inline;
24252387
padding: 0.2em 0.6em 0.3em;

0 commit comments

Comments
 (0)