Skip to content

Commit 9825971

Browse files
committed
refactor: use constants for urls
1 parent da77ead commit 9825971

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

src/Pages/GlobalConfigurations/Authorization/authorization.service.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { SortableKeys as PermissionGroupListSortableKeys } from './PermissionGro
2727
// User Permissions
2828
export const getUserById = async (userId: User['id']): Promise<User> => {
2929
try {
30-
const { result } = (await get(`user/${userId}`)) as ResponseType<UserDto>
30+
const { result } = (await get(`${Routes.USER}/${userId}`)) as ResponseType<UserDto>
3131

3232
return transformUserResponse(result)
3333
} catch (error) {
@@ -41,10 +41,10 @@ export const createOrUpdateUser = (data: UserCreateOrUpdatePayload) => {
4141
const options: APIOptions = {
4242
timeout: window._env_.CONFIGURABLE_TIMEOUT ? parseInt(window._env_.CONFIGURABLE_TIMEOUT, 10) : null,
4343
}
44-
return isUpdate ? put('user', data, options) : post('user', data, options)
44+
return isUpdate ? put(Routes.USER, data, options) : post(Routes.USER, data, options)
4545
}
4646

47-
export const deleteUser = (userId: User['id']) => trash(`user/${userId}`)
47+
export const deleteUser = (userId: User['id']) => trash(`${Routes.USER}/${userId}`)
4848

4949
export const getUserList = async (
5050
queryParams: BaseFilterQueryParams<UserListSortableKeys>,
@@ -56,7 +56,7 @@ export const getUserList = async (
5656
try {
5757
const {
5858
result: { users, totalCount },
59-
} = (await get(getUrlWithSearchParams('user', queryParams ?? {}), { signal })) as ResponseType<{
59+
} = (await get(getUrlWithSearchParams(Routes.USER, queryParams ?? {}), { signal })) as ResponseType<{
6060
users: UserDto[]
6161
totalCount: number
6262
}>
@@ -76,7 +76,7 @@ export const getUserList = async (
7676
// Permission Groups
7777
export const getPermissionGroupById = async (groupId: PermissionGroup['id']): Promise<PermissionGroup> => {
7878
try {
79-
const { result } = (await get(`user/role/group/${groupId}`)) as ResponseType<PermissionGroupDto>
79+
const { result } = (await get(`${Routes.USER_ROLE_GROUP}/${groupId}`)) as ResponseType<PermissionGroupDto>
8080
return result
8181
} catch (error) {
8282
showError(error)
@@ -90,7 +90,7 @@ export const createOrUpdatePermissionGroup = (payload: PermissionGroupCreateOrUp
9090
timeout: window._env_.CONFIGURABLE_TIMEOUT ? parseInt(window._env_.CONFIGURABLE_TIMEOUT, 10) : null,
9191
}
9292

93-
return isUpdate ? put(Routes.USER_ROLE_GROUP, payload, options) : post('user/role/group', payload, options)
93+
return isUpdate ? put(Routes.USER_ROLE_GROUP, payload, options) : post(Routes.USER_ROLE_GROUP, payload, options)
9494
}
9595

9696
export const getPermissionGroupList = async (
@@ -103,7 +103,7 @@ export const getPermissionGroupList = async (
103103
try {
104104
const {
105105
result: { roleGroups: permissionGroups, totalCount },
106-
} = (await get(getUrlWithSearchParams('user/role/group', queryParams ?? {}), { signal })) as ResponseType<{
106+
} = (await get(getUrlWithSearchParams(Routes.USER_ROLE_GROUP, queryParams ?? {}), { signal })) as ResponseType<{
107107
roleGroups: PermissionGroupDto[]
108108
totalCount: number
109109
}>
@@ -120,7 +120,7 @@ export const getPermissionGroupList = async (
120120
}
121121
}
122122

123-
export const deletePermissionGroup = (id: PermissionGroup['id']) => trash(`user/role/group/${id}`)
123+
export const deletePermissionGroup = (id: PermissionGroup['id']) => trash(`${Routes.USER_ROLE_GROUP}/${id}`)
124124

125125
// Others
126126
export const getCustomRoles = async (): Promise<ResponseType<CustomRoles[]>> => {

src/config/constants.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,7 @@ export const Routes = {
245245
SCOPED_GLOBAL_VARIABLES: 'global/variables',
246246
SCOPED_GLOBAL_VARIABLES_DETAIL: 'global/variables/detail',
247247
GVK: 'gvk',
248+
USER: 'user'
248249
}
249250

250251
export const ViewType = {

0 commit comments

Comments
 (0)