Skip to content

Commit 98aa154

Browse files
Merge pull request #1580 from devtron-labs/chore/remove-window-size
chore: remove and replace useWindowSize from common
2 parents 2bff764 + f6f910f commit 98aa154

File tree

7 files changed

+6
-39
lines changed

7 files changed

+6
-39
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"homepage": "/dashboard",
66
"dependencies": {
7-
"@devtron-labs/devtron-fe-common-lib": "0.0.51",
7+
"@devtron-labs/devtron-fe-common-lib": "0.0.52",
88
"@rjsf/core": "^5.13.3",
99
"@rjsf/utils": "^5.13.3",
1010
"@rjsf/validator-ajv8": "^5.13.3",

src/components/CodeEditor/CodeEditor.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import React, { useEffect, useCallback, useReducer, useRef } from 'react'
22
import MonacoEditor, { MonacoDiffEditor } from 'react-monaco-editor';
3-
import { useJsonYaml, Select, RadioGroup, useWindowSize } from '../common'
4-
import { Progressing, copyToClipboard } from '@devtron-labs/devtron-fe-common-lib'
3+
import { useJsonYaml, Select, RadioGroup } from '../common'
4+
import { Progressing, copyToClipboard, useWindowSize } from '@devtron-labs/devtron-fe-common-lib'
55
import { ReactComponent as ClipboardIcon } from '../../assets/icons/ic-copy.svg';
66
import { ReactComponent as Info } from '../../assets/icons/ic-info-filled.svg';
77
import { ReactComponent as ErrorIcon } from '../../assets/icons/ic-error-exclamation.svg';

src/components/app/ResponsiveDrawer.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import { useEffectAfterMount } from '@devtron-labs/devtron-fe-common-lib';
21
import React, {useEffect} from 'react'
3-
import { useWindowSize } from '../common';
2+
import { useEffectAfterMount, useWindowSize } from '@devtron-labs/devtron-fe-common-lib'
43

54
export default function ResponsiveDrawer({ initialHeight = 36, minHeight = 100, defaultHeight = 500, minimumTopMargin = 100, isDetailedView, onHeightChange = null, className = "", children, anchor=null }) {
65
let dimensions = useWindowSize()

src/components/common/FloatingVariablesSuggestions/FloatingVariablesSuggestions.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React, { useState, useRef, useMemo, useCallback, memo, useEffect } from 'react'
2-
import { useAsync } from '@devtron-labs/devtron-fe-common-lib'
2+
import { useAsync, useWindowSize } from '@devtron-labs/devtron-fe-common-lib'
33
import Draggable from 'react-draggable'
4-
import { useWindowSize } from '../helpers/UseWindowSize'
54
import Suggestions from './Suggestions'
65
import { getScopedVariables } from './service'
76
import { FloatingVariablesSuggestionsProps } from './types'

src/components/common/helpers/Helpers.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import {
66
DeploymentAppTypes,
77
getLoginInfo,
88
APIOptions,
9+
useWindowSize,
910
} from '@devtron-labs/devtron-fe-common-lib'
1011
import YAML from 'yaml'
11-
import { useWindowSize } from './UseWindowSize'
1212
import { Link } from 'react-router-dom'
1313
import ReactGA from 'react-ga4'
1414
import { getDateInMilliseconds } from '../../apiTokens/authorization.utils'

src/components/common/helpers/UseWindowSize.tsx

Lines changed: 0 additions & 30 deletions
This file was deleted.

src/components/common/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export * from './helpers/isSubset'
1818
export * from './helpers/workflowURL'
1919
export * from './helpers/isEmpty'
2020
export * from './helpers/git'
21-
export * from './helpers/UseWindowSize'
2221
export * from './helpers/util'
2322
export * from './helpers/time'
2423
export * from './ToastBody'

0 commit comments

Comments
 (0)