Skip to content

Commit a5dda2c

Browse files
committed
Merge branch 'main' of github.com:devtron-labs/dashboard into feat/node-search-filters
2 parents 53747f5 + 633aa8b commit a5dda2c

File tree

9 files changed

+27
-21
lines changed

9 files changed

+27
-21
lines changed

.env

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,4 @@ FEATURE_INFRA_PROVISION_INFO_BLOCK_HIDE=false
7676
FEATURE_GROUPED_APP_LIST_FILTERS_ENABLE=false
7777
FEATURE_FLUX_DEPLOYMENTS_ENABLE=false
7878
FEATURE_LINK_EXTERNAL_FLUX_ENABLE=false
79+
FEATURE_CANARY_ROLLOUT_PROGRESS_ENABLE=true

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"private": true,
55
"homepage": "/dashboard",
66
"dependencies": {
7-
"@devtron-labs/devtron-fe-common-lib": "1.18.0-pre-0",
7+
"@devtron-labs/devtron-fe-common-lib": "1.18.1-pre-0",
88
"@esbuild-plugins/node-globals-polyfill": "0.2.3",
99
"@rjsf/core": "^5.13.3",
1010
"@rjsf/utils": "^5.13.3",

src/Pages/GlobalConfigurations/Authorization/Shared/components/AppPermissions/AppOrJobSelector.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const AppOrJobSelector = ({
7070
_permission.entityName.filter((option) => option.value !== SELECT_ALL_VALUE).map((app) => app.label) ??
7171
[]
7272
const { appIdWorkflowNamesMapping } = await getUserAccessAllWorkflows({
73-
appIds: jobNames,
73+
appNames: jobNames,
7474
options: { abortControllerRef },
7575
})
7676
const workflowOptions = getWorkflowOptions(appIdWorkflowNamesMapping)

src/Pages/GlobalConfigurations/Authorization/Shared/components/AppPermissions/AppPermissions.component.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ const AppPermissions = () => {
345345
async function setAllWorkflows(jobOptions) {
346346
const jobNames = jobOptions.filter((job) => job.value !== SELECT_ALL_VALUE).map((job) => job.label)
347347
try {
348-
const result = await getUserAccessAllWorkflows(jobNames)
348+
const result = await getUserAccessAllWorkflows({ appNames: jobNames })
349349

350350
const workflowOptions = getWorkflowOptions(result?.appIdWorkflowNamesMapping)
351351
return [

src/Pages/GlobalConfigurations/Authorization/authorization.service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,10 +312,10 @@ export const getUserAccessClusterList = () =>
312312
payload: { entity: EntityTypes.CLUSTER },
313313
})
314314

315-
export const getUserAccessAllWorkflows = ({ appIds, options }: GetUserAccessAllWorkflowsParams) =>
315+
export const getUserAccessAllWorkflows = ({ appNames, options }: GetUserAccessAllWorkflowsParams) =>
316316
getUserResourceOptions<AppIdWorkflowNamesMapping>({
317-
kind: UserAccessResourceKind.JOBS,
318-
payload: { entity: EntityTypes.JOB, appIds },
317+
kind: UserAccessResourceKind.WORKFLOW,
318+
payload: { entity: EntityTypes.JOB, appNames },
319319
options,
320320
})
321321

src/Pages/GlobalConfigurations/Authorization/types.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@ export interface GetUserPermissionResourcesPayload
347347
accessType?: ACCESS_TYPE_MAP.DEVTRON_APPS | ACCESS_TYPE_MAP.HELM_APPS
348348
teamIds?: number[]
349349
appIds?: string[]
350+
appNames?: string[]
350351
}
351352

352353
export interface GetUserResourceOptionsProps {
@@ -356,5 +357,5 @@ export interface GetUserResourceOptionsProps {
356357
}
357358

358359
export interface GetUserAccessAllWorkflowsParams
359-
extends Pick<GetUserPermissionResourcesPayload, 'appIds'>,
360+
extends Pick<GetUserPermissionResourcesPayload, 'appNames'>,
360361
Pick<GetUserResourceOptionsProps, 'options'> {}

src/Pages/Shared/ConfigMapSecret/ConfigMapSecretContainer.tsx

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -328,15 +328,6 @@ export const ConfigMapSecretContainer = ({
328328
}
329329
}, [configMapSecretResLoading, configMapSecretRes])
330330

331-
// CONFIGMAP/SECRET DELETED
332-
const configHasBeenDeleted = useMemo(
333-
() =>
334-
!configMapSecretResLoading && configMapSecretRes
335-
? !configMapSecretData && !inheritedConfigMapSecretData && !draftData
336-
: null,
337-
[configMapSecretResLoading, configMapSecretRes],
338-
)
339-
340331
// CONFIGMAP/SECRET ERROR
341332
const configMapSecretResErr = useMemo(
342333
() =>
@@ -348,6 +339,18 @@ export const ConfigMapSecretContainer = ({
348339
[configMapSecretResLoading, configMapSecretRes],
349340
)
350341

342+
// CONFIGMAP/SECRET DELETED
343+
const configHasBeenDeleted = useMemo(
344+
() =>
345+
!configMapSecretResLoading &&
346+
configMapSecretRes &&
347+
!configMapSecretResErr &&
348+
!configMapSecretData &&
349+
!inheritedConfigMapSecretData &&
350+
!draftData,
351+
[configMapSecretResLoading, configMapSecretRes, configMapSecretResErr],
352+
)
353+
351354
// ASYNC CALL - CONFIGMAP/SECRET RESOLVED DATA
352355
const [resolvedScopeVariablesResLoading, resolvedScopeVariablesRes, reloadResolvedScopeVariablesResErr] = useAsync(
353356
() =>

src/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ if (!window || !window._env_) {
181181
FEATURE_GROUPED_APP_LIST_FILTERS_ENABLE: true,
182182
FEATURE_FLUX_DEPLOYMENTS_ENABLE: false,
183183
FEATURE_LINK_EXTERNAL_FLUX_ENABLE: false,
184+
FEATURE_CANARY_ROLLOUT_PROGRESS_ENABLE: true,
184185
}
185186
}
186187

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1722,9 +1722,9 @@ __metadata:
17221722
languageName: node
17231723
linkType: hard
17241724

1725-
"@devtron-labs/devtron-fe-common-lib@npm:1.18.0-pre-0":
1726-
version: 1.18.0-pre-0
1727-
resolution: "@devtron-labs/devtron-fe-common-lib@npm:1.18.0-pre-0"
1725+
"@devtron-labs/devtron-fe-common-lib@npm:1.18.1-pre-0":
1726+
version: 1.18.1-pre-0
1727+
resolution: "@devtron-labs/devtron-fe-common-lib@npm:1.18.1-pre-0"
17281728
dependencies:
17291729
"@codemirror/autocomplete": "npm:6.18.6"
17301730
"@codemirror/lang-json": "npm:6.0.1"
@@ -1774,7 +1774,7 @@ __metadata:
17741774
react-select: 5.8.0
17751775
rxjs: ^7.8.1
17761776
yaml: ^2.4.1
1777-
checksum: 10c0/1bcecf97315a63222d7063d181ec751fb7a8970e0de585e71d0725acaa2d0d60e264311404bd1c333ae2623fc9607ad965e47a26948156a7e4942b77bb1c1303
1777+
checksum: 10c0/de563e385f44c1ed357fad7c2ce01989857a7acd3164958b7817e0a64fbb61648e4bff4aee207c3de2c18027b6364ab8f67a962420ddfd7aeebf813500dd985d
17781778
languageName: node
17791779
linkType: hard
17801780

@@ -5721,7 +5721,7 @@ __metadata:
57215721
version: 0.0.0-use.local
57225722
resolution: "dashboard@workspace:."
57235723
dependencies:
5724-
"@devtron-labs/devtron-fe-common-lib": "npm:1.18.0-pre-0"
5724+
"@devtron-labs/devtron-fe-common-lib": "npm:1.18.1-pre-0"
57255725
"@esbuild-plugins/node-globals-polyfill": "npm:0.2.3"
57265726
"@playwright/test": "npm:^1.32.1"
57275727
"@rjsf/core": "npm:^5.13.3"

0 commit comments

Comments
 (0)