Skip to content

Commit a990872

Browse files
committed
Merge branch 'main' into custom-input-v2
2 parents a541c8f + 43a803c commit a990872

File tree

9 files changed

+13
-13
lines changed

9 files changed

+13
-13
lines changed

src/components/CIPipelineN/YAMLScriptComponent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export function YAMLScriptComponent({
5656
components={{
5757
IndicatorSeparator: null,
5858
}}
59-
menuPortalTarget={document.getElementById('visible-modal')}
59+
menuPosition="fixed"
6060
/>
6161
)}
6262
</div>

src/components/app/details/appConfig/AppComposeRouter.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export default function AppComposeRouter({
5959
isBaseConfigProtected,
6060
reloadEnvironments,
6161
configProtectionData,
62-
filteredEnvIds
62+
filteredEnvIds,
6363
}: AppComposeRouterProps) {
6464
const { path } = useRouteMatch()
6565
const renderJobViewRoutes = (): JSX.Element => {
@@ -205,7 +205,7 @@ export default function AppComposeRouter({
205205
</Route>,
206206
<Route
207207
key={`${path}/${URLS.APP_ENV_OVERRIDE_CONFIG}`}
208-
path={`${path}/${URLS.APP_ENV_OVERRIDE_CONFIG}/:envId(\\d+)?/:name?`}
208+
path={`${path}/${URLS.APP_ENV_OVERRIDE_CONFIG}/:envId(\\d+)?`}
209209
render={(props) => (
210210
<EnvironmentOverride environments={environments} reloadEnvironments={reloadEnvironments} />
211211
)}

src/components/app/details/appDetails/AppDetails.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1442,7 +1442,7 @@ export function TimeRangeSelector({
14421442
options={options.map((time) => ({ label: time, value: time }))}
14431443
value={{ label: selectedRange, value: selectedRange }}
14441444
onChange={(selected) => selectRange(selected.value)}
1445-
menuPortalTarget={document.body}
1445+
menuPosition="fixed"
14461446
components={{ IndicatorSeparator: null, ValueContainer, Option }}
14471447
styles={{
14481448
...multiSelectStyles,

src/components/app/details/cicdHistory/Sidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ const Sidebar = React.memo(
133133
DropdownIndicator,
134134
}}
135135
styles={FILTER_STYLE}
136-
menuPortalTarget={document.body}
136+
menuPosition="fixed"
137137
/>
138138
</div>
139139

src/components/cdPipeline/BuildCD.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ export default function BuildCD({
331331
<div className="w-50 mr-8">
332332
<div className="form__label dc__required-field">Environment</div>
333333
<ReactSelect
334-
menuPortalTarget={isAdvanced ? null : document.getElementById('visible-modal')}
334+
menuPosition={isAdvanced ? null : "fixed"}
335335
closeMenuOnScroll={true}
336336
isDisabled={!!cdPipelineId}
337337
classNamePrefix="cd-pipeline-environment-dropdown"
@@ -549,7 +549,7 @@ export default function BuildCD({
549549
<p className="fs-14 fw-6 cn-9 mb-8 mt-16">Deployment Strategy</p>
550550
<p className="fs-13 fw-5 cn-7 mb-8">Configure deployment preferences for this pipeline</p>
551551
<ReactSelect
552-
menuPortalTarget={document.getElementById('visible-modal')}
552+
menuPosition="fixed"
553553
closeMenuOnScroll={true}
554554
classNamePrefix="deployment-strategy-dropdown"
555555
isSearchable={false}

src/components/cdPipeline/CDPipeline.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,7 +1208,7 @@ export default class CDPipeline extends Component<CDPipelineProps, CDPipelineSta
12081208
<div className="form__row">
12091209
<label className="form__label form__label--sentence dc__bold">Select Configmap and Secrets</label>
12101210
<ReactSelect
1211-
menuPortalTarget={this.state.isAdvanced ? null : document.getElementById('visible-modal')}
1211+
menuPosition={this.state.isAdvanced ? null : "fixed"}
12121212
closeMenuOnScroll={true}
12131213
classNamePrefix="select-config-secret-dropdown"
12141214
isMulti={true}
@@ -1483,7 +1483,7 @@ export default class CDPipeline extends Component<CDPipelineProps, CDPipelineSta
14831483
<div className="w-50 mr-8">
14841484
<div className="form__label dc__required-field">Environment</div>
14851485
<ReactSelect
1486-
menuPortalTarget={this.state.isAdvanced ? null : document.getElementById('visible-modal')}
1486+
menuPosition={this.state.isAdvanced ? null : "fixed"}
14871487
closeMenuOnScroll={true}
14881488
isDisabled={!!this.props.match.params.cdPipelineId}
14891489
classNamePrefix="cd-pipeline-environment-dropdown"
@@ -1761,7 +1761,7 @@ export default class CDPipeline extends Component<CDPipelineProps, CDPipelineSta
17611761
<p className="fs-14 fw-6 cn-9 mb-8 mt-20">Deployment Strategy</p>
17621762
<p className="fs-13 fw-5 cn-7 mb-8">Configure deployment preferences for this pipeline</p>
17631763
<ReactSelect
1764-
menuPortalTarget={document.getElementById('visible-modal')}
1764+
menuPosition="fixed"
17651765
closeMenuOnScroll={true}
17661766
classNamePrefix="deployment-strategy-dropdown"
17671767
isSearchable={false}

src/components/ciPipeline/SourceMaterials.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export const SourceMaterials: React.FC<SourceMaterialsProps> = function (props)
161161
placeholder="Source Type"
162162
classNamePrefix={`select-build-pipeline-sourcetype-${index}`}
163163
isSearchable={false}
164-
menuPortalTarget={document.getElementById('visible-modal')}
164+
menuPosition="fixed"
165165
options={
166166
!isMultiGit
167167
? props.ciPipelineSourceTypeOptions

src/components/cluster/UseNameListDropdown.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export default function UserNameDropDownList({ clusterDetail, selectedUserNameOp
2525
options={userNameOptions}
2626
value={selectedUserNameOptions[clusterDetail.cluster_name]}
2727
isSearchable={false}
28-
menuPortalTarget={document.getElementById('visible-modal')}
28+
menuPosition="fixed"
2929
onChange={handleUserChange}
3030
menuPlacement="auto"
3131
components={{

src/components/security/SecurityPolicyEdit.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ export class SecurityPolicyEdit extends Component<FetchPolicyQueryParams, GetVul
371371
</td>
372372
<td className="security-policy__data-cell">
373373
<ReactSelect
374-
menuPortalTarget={document.getElementById('root')}
374+
menuPosition="fixed"
375375
closeMenuOnScroll={true}
376376
value={selectedValue}
377377
onChange={(selected) => {

0 commit comments

Comments
 (0)