Skip to content

Commit abd8136

Browse files
committed
feat: AppDetails - refactor component to have horizontal-scroll for app-info-cards
1 parent a590083 commit abd8136

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

src/components/app/details/appDetails/AppDetails.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -718,9 +718,7 @@ const Details: React.FC<DetailsType> = ({
718718
const isDeploymentAppDeleting = appDetails?.deploymentAppDeleteRequest || false
719719
return (
720720
<>
721-
<div
722-
className={`w-100 pt-16 pr-20 pb-16 pl-20 dc__gap-16 ${isDeploymentAppDeleting ? 'app-info-bg' : 'app-info-bg-gradient'}`}
723-
>
721+
<div className={`w-100 dc__gap-16 ${isDeploymentAppDeleting ? 'app-info-bg' : 'app-info-bg-gradient'}`}>
724722
<SourceInfo
725723
appDetails={appDetails}
726724
setDetailed={setShowAppStatusModal}

src/components/app/details/appDetails/SourceInfo.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ export const SourceInfo = ({
171171

172172
const renderAppDetailsCDButton = () => {
173173
const { buttonStyle, iconName } = getDeployButtonConfig(deploymentUserActionState)
174-
174+
175175
return (
176176
<Button
177177
dataTestId="deploy-button"
@@ -208,7 +208,7 @@ export const SourceInfo = ({
208208
: ''
209209

210210
return (
211-
<div className="flex left w-100 h-40">
211+
<div className="flex left w-100 pt-16 px-20">
212212
<AppEnvSelector {...(isAppView ? { isAppView, environments } : { isAppView: false, applications })} />
213213
{appDetails?.deploymentAppType && (
214214
<div className={`flex ${!appDetails.isVirtualEnvironment ? 'ml-16' : ''}`}>
@@ -415,7 +415,7 @@ export const SourceInfo = ({
415415
? shimmerLoaderBlocks()
416416
: !isdeploymentAppDeleting &&
417417
environment && (
418-
<div className="flex left w-100 flex-wrap dc__row-gap-12">
418+
<div className="app-details-info-card-container flex left w-100 dc__row-gap-12 pb-16 dc__overflow-auto">
419419
{status && (
420420
<AppStatusCard
421421
// TODO: Fix and remove

src/components/app/details/appDetails/appDetails.scss

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,6 +1385,20 @@ table.resource-tree {
13851385
}
13861386
}
13871387

1388+
.app-details-info-card-container {
1389+
> * {
1390+
flex-shrink: 0;
1391+
1392+
&:first-child {
1393+
margin-left: 20px;
1394+
}
1395+
1396+
&:last-child {
1397+
margin-right: 20px;
1398+
}
1399+
}
1400+
}
1401+
13881402
.deployed-commit-card {
13891403
&:hover {
13901404
.app-details-info-card:not(:first-child) {

0 commit comments

Comments
 (0)